[1/2] pb-sos: capture Skiboot log
diff mbox

Message ID 20170711180405.11868-1-gpiccoli@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

Guilherme G. Piccoli July 11, 2017, 6:04 p.m. UTC
Makes sense to capture Skiboot log in pb-sos, specially since
it might help clarify about HW problems, like PCI initialization
failures.

Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
---
 utils/pb-sos | 3 +++
 1 file changed, 3 insertions(+)

Comments

Samuel Mendoza-Jonas July 12, 2017, 4:59 a.m. UTC | #1
On Tue, 2017-07-11 at 15:04 -0300, Guilherme G. Piccoli wrote:
> Makes sense to capture Skiboot log in pb-sos, specially since
> it might help clarify about HW problems, like PCI initialization
> failures.

Good idea! Good catch on the compression too. Merged these two as
3fc71b6 with an extra log message.

Thanks!
Sam

> 
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
> ---
>  utils/pb-sos | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/utils/pb-sos b/utils/pb-sos
> index 2e9802e..c619d7e 100755
> --- a/utils/pb-sos
> +++ b/utils/pb-sos
> @@ -63,6 +63,9 @@ fi
>  log "Adding dmesg"
>  dmesg > /$diagdir/dmesg
>  
> +#Add Skiboot log
> +cat /sys/firmware/opal/msglog > /$diagdir/msglog
> +
>  log "Compressing..."
>  cd /
>  tar $tarflags -cf $tarfile $diagdir
Guilherme G. Piccoli July 12, 2017, 12:01 p.m. UTC | #2
On 07/12/2017 01:59 AM, Samuel Mendoza-Jonas wrote:
> On Tue, 2017-07-11 at 15:04 -0300, Guilherme G. Piccoli wrote:
>> Makes sense to capture Skiboot log in pb-sos, specially since
>> it might help clarify about HW problems, like PCI initialization
>> failures.
> 
> Good idea! Good catch on the compression too. Merged these two as
> 3fc71b6 with an extra log message.
> 
> Thanks!
> Sam

Thanks Sam!

Patch
diff mbox

diff --git a/utils/pb-sos b/utils/pb-sos
index 2e9802e..c619d7e 100755
--- a/utils/pb-sos
+++ b/utils/pb-sos
@@ -63,6 +63,9 @@  fi
 log "Adding dmesg"
 dmesg > /$diagdir/dmesg
 
+#Add Skiboot log
+cat /sys/firmware/opal/msglog > /$diagdir/msglog
+
 log "Compressing..."
 cd /
 tar $tarflags -cf $tarfile $diagdir