Patchwork [U-Boot] PATCH][v0][85xx/P1_P2] Fix wrong CONFIG_SYS_MPC85xx_SERDES1_ADDR #define

login
register
mail settings
Submitter Prabhakar Kushwaha
Date Jan. 13, 2011, 5:56 a.m.
Message ID <071A08F2C6A57E4E94D980ECA553F874070BF5@039-SN1MPN1-004.039d.mgd.msft.net>
Download mbox | patch
Permalink /patch/78658/
State Changes Requested
Headers show

Comments

Prabhakar Kushwaha - Jan. 13, 2011, 5:56 a.m.
CONFIG_SYS_MPC85xx_SERDES1_ADDR was defined wrong as CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET. It should be CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES1_OFFSET.

Signed-off-by: Prabhakar <prabhakar@freescale.com>
---

 arch/powerpc/include/asm/immap_85xx.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Wolfgang Denk - Jan. 13, 2011, 6:12 a.m.
Dear Kushwaha Prabhakar-B32579,

In message <071A08F2C6A57E4E94D980ECA553F874070BF5@039-SN1MPN1-004.039d.mgd.msft.net> you wrote:
> 
> CONFIG_SYS_MPC85xx_SERDES1_ADDR was defined wrong as CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET. It should be CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES1_OFFSET.

Please restrict the line length of the commit message to < 70
characters.

> 
> diff --git a/arch/powerpc/include/asm/immap_85xx.h b/arch/powerpc/include/asm/immap_85xx.h
> index 81f215b..7b371e3 100644
> --- a/arch/powerpc/include/asm/immap_85xx.h
> +++ b/arch/powerpc/include/asm/immap_85xx.h
> @@ -2308,7 +2308,7 @@ typedef struct ccsr_pme {  #define CONFIG_SYS_MPC85xx_CPM_ADDR \
>  	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_CPM_OFFSET)  #define CONFIG_SYS_MPC85xx_SERDES1_ADDR \
> -	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
> +	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES1_OFFSET)
>  #define CONFIG_SYS_MPC85xx_SERDES2_ADDR \
>  	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
>  #define CONFIG_SYS_FSL_CORENET_SERDES_ADDR \

This patch looks corrupted and does not apply.

Best regards,

Wolfgang Denk
Prabhakar Kushwaha - Jan. 13, 2011, 6:24 a.m.
Thanks for your comments. Please see my response inline. 

Regards,
Prabhakar

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd@denx.de]
> Sent: Thursday, January 13, 2011 11:42 AM
> To: Kushwaha Prabhakar-B32579
> Cc: u-boot@lists.denx.de
> Subject: Re: [U-Boot] PATCH][v0][85xx/P1_P2] Fix wrong
> CONFIG_SYS_MPC85xx_SERDES1_ADDR #define
> 
> Dear Kushwaha Prabhakar-B32579,
> 
> In message <071A08F2C6A57E4E94D980ECA553F874070BF5@039-SN1MPN1-
> 004.039d.mgd.msft.net> you wrote:
> >
> > CONFIG_SYS_MPC85xx_SERDES1_ADDR was defined wrong as CONFIG_SYS_IMMR +
> CONFIG_SYS_MPC85xx_SERDES2_OFFSET. It should be CONFIG_SYS_IMMR +
> CONFIG_SYS_MPC85xx_SERDES1_OFFSET.
> 
> Please restrict the line length of the commit message to < 70 characters.
> 
I will correct it

> >
> > diff --git a/arch/powerpc/include/asm/immap_85xx.h
> > b/arch/powerpc/include/asm/immap_85xx.h
> > index 81f215b..7b371e3 100644
> > --- a/arch/powerpc/include/asm/immap_85xx.h
> > +++ b/arch/powerpc/include/asm/immap_85xx.h
> > @@ -2308,7 +2308,7 @@ typedef struct ccsr_pme {  #define
> CONFIG_SYS_MPC85xx_CPM_ADDR \
> >  	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_CPM_OFFSET)  #define
> CONFIG_SYS_MPC85xx_SERDES1_ADDR \
> > -	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
> > +	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES1_OFFSET)
> >  #define CONFIG_SYS_MPC85xx_SERDES2_ADDR \
> >  	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
> >  #define CONFIG_SYS_FSL_CORENET_SERDES_ADDR \
> 
> This patch looks corrupted and does not apply.
> 

I will rebase it and send it soon. 


Kind Regards,
Prabhakar

Patch

diff --git a/arch/powerpc/include/asm/immap_85xx.h b/arch/powerpc/include/asm/immap_85xx.h
index 81f215b..7b371e3 100644
--- a/arch/powerpc/include/asm/immap_85xx.h
+++ b/arch/powerpc/include/asm/immap_85xx.h
@@ -2308,7 +2308,7 @@  typedef struct ccsr_pme {  #define CONFIG_SYS_MPC85xx_CPM_ADDR \
 	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_CPM_OFFSET)  #define CONFIG_SYS_MPC85xx_SERDES1_ADDR \
-	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
+	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES1_OFFSET)
 #define CONFIG_SYS_MPC85xx_SERDES2_ADDR \
 	(CONFIG_SYS_IMMR + CONFIG_SYS_MPC85xx_SERDES2_OFFSET)
 #define CONFIG_SYS_FSL_CORENET_SERDES_ADDR \
--
1.6.3.1