diff mbox

[v2] build: disable Xen on ARM

Message ID 20170711100049.20513-1-pbonzini@redhat.com
State New
Headers show

Commit Message

Paolo Bonzini July 11, 2017, 10 a.m. UTC
While ARM could present the xenpv machine, it does not and trying to enable
it breaks compilation.  Revert to the previous test which only looked at
$target_name, not $cpu.

Fixes: 3b6b75506de44c5070639943c30a0ad5850f5d02
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Peter Maydell July 11, 2017, 12:47 p.m. UTC | #1
On 11 July 2017 at 11:00, Paolo Bonzini <pbonzini@redhat.com> wrote:
> While ARM could present the xenpv machine, it does not and trying to enable
> it breaks compilation.  Revert to the previous test which only looked at
> $target_name, not $cpu.
>
> Fixes: 3b6b75506de44c5070639943c30a0ad5850f5d02
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 806658c98b..5096cbcf14 100755
> --- a/configure
> +++ b/configure
> @@ -202,9 +202,9 @@ supported_kvm_target() {
>  supported_xen_target() {
>      test "$xen" = "yes" || return 1
>      glob "$1" "*-softmmu" || return 1
> -    case "${1%-softmmu}:$cpu" in
> -        arm:arm | aarch64:aarch64 | \
> -        i386:i386 | i386:x86_64 | x86_64:i386 | x86_64:x86_64)
> +    # Only i386 and x86_64 provide the xenpv machine.
> +    case "${1%-softmmu}" in
> +        i386|x86_64)
>              return 0
>          ;;
>      esac

Thanks, applied to master as a build fix.

-- PMM
diff mbox

Patch

diff --git a/configure b/configure
index 806658c98b..5096cbcf14 100755
--- a/configure
+++ b/configure
@@ -202,9 +202,9 @@  supported_kvm_target() {
 supported_xen_target() {
     test "$xen" = "yes" || return 1
     glob "$1" "*-softmmu" || return 1
-    case "${1%-softmmu}:$cpu" in
-        arm:arm | aarch64:aarch64 | \
-        i386:i386 | i386:x86_64 | x86_64:i386 | x86_64:x86_64)
+    # Only i386 and x86_64 provide the xenpv machine.
+    case "${1%-softmmu}" in
+        i386|x86_64)
             return 0
         ;;
     esac