From patchwork Wed Jan 12 21:08:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Neira Ayuso X-Patchwork-Id: 78615 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DB238B6F10 for ; Thu, 13 Jan 2011 08:08:28 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756417Ab1ALVIU (ORCPT ); Wed, 12 Jan 2011 16:08:20 -0500 Received: from mail.us.es ([193.147.175.20]:32962 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756203Ab1ALVIS (ORCPT ); Wed, 12 Jan 2011 16:08:18 -0500 Received: (qmail 5676 invoked from network); 12 Jan 2011 22:08:16 +0100 Received: from unknown (HELO us.es) (192.168.2.12) by us.es with SMTP; 12 Jan 2011 22:08:16 +0100 Received: (qmail 10427 invoked by uid 507); 12 Jan 2011 21:08:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on antivirus2 X-Spam-Level: **** X-Spam-Status: No, score=4.4 required=7.5 tests=BAYES_50, RCVD_IN_BRBL_LASTEXT, RCVD_IN_PBL, RCVD_IN_RP_RNBL, RCVD_IN_SORBS_DUL, RDNS_DYNAMIC autolearn=disabled version=3.3.1 Received: from 127.0.0.1 by antivirus2 (envelope-from , uid 501) with qmail-scanner-2.08 (clamdscan: 0.96.5/12511. Clear:RC:1(127.0.0.1):. Processed in 0.041983 secs); 12 Jan 2011 21:08:14 -0000 Received: from unknown (HELO antivirus2) (127.0.0.1) by us.es with SMTP; 12 Jan 2011 21:08:14 -0000 Received: from 192.168.1.13 (192.168.1.13) by antivirus2 (F-Secure/fsigk_smtp/403/antivirus2); Wed, 12 Jan 2011 22:08:14 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/403/antivirus2) Received: (qmail 11007 invoked from network); 12 Jan 2011 22:08:13 +0100 Received: from 94.220.222.87.dynamic.jazztel.es (HELO ?192.168.1.128?) (pneira@us.es@87.222.220.94) by us.es with AES256-SHA encrypted SMTP; 12 Jan 2011 22:08:13 +0100 Message-ID: <4D2E183C.4070908@netfilter.org> Date: Wed, 12 Jan 2011 22:08:12 +0100 From: Pablo Neira Ayuso User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.10) Gecko/20100619 Icedove/3.0.5 MIME-Version: 1.0 To: Jan Engelhardt CC: Valdis.Kletnieks@vt.edu, Patrick McHardy , "David S. Miller" , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: XT_MATCH_REALM Kconfig whinge... References: <20519.1294859715@localhost> <4D2E057D.30707@netfilter.org> In-Reply-To: X-Enigmail-Version: 1.0.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/01/11 21:57, Jan Engelhardt wrote: > On Wednesday 2011-01-12 20:48, Pablo Neira Ayuso wrote: > >> On 12/01/11 20:15, Valdis.Kletnieks@vt.edu wrote: >>> scripts/kconfig/conf --silentoldconfig Kconfig >>> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) >>> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) >> >> Does this fix your problem? >> > > diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig > index 1534f2b..ae56764 100644 > --- a/net/netfilter/Kconfig > +++ b/net/netfilter/Kconfig > @@ -886,7 +886,8 @@ config NETFILTER_XT_MATCH_RATEEST > config NETFILTER_XT_MATCH_REALM > tristate '"realm" match support' > depends on NETFILTER_ADVANCED > - select NET_CLS_ROUTE > + depends on NET_SCHED > + depends on NET_CLS_ROUTE > help > This option adds a `realm' match, which allows you to use the realm > key from the routing subsystem inside iptables. > > > This patch is not right. The select should just be removed, because > xt_realm is useful even without SCHED and CLS_ROUTE. I wonder why NET_CLS_ROUTE has been there as dependency. Then this patch should be fine. netfilter: xt_realm: fix unmet direct dependencies From: Pablo Neira Ayuso scripts/kconfig/conf --silentoldconfig Kconfig warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED) Jan Engelhardt spotted that NET_CLS_ROUTE is a superfluous dependency, for that reason, this patch remove it. Reported by: Valdis Kletnieks Signed-off-by: Pablo Neira Ayuso --- net/netfilter/Kconfig | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 1534f2b..8960260 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -886,7 +886,6 @@ config NETFILTER_XT_MATCH_RATEEST config NETFILTER_XT_MATCH_REALM tristate '"realm" match support' depends on NETFILTER_ADVANCED - select NET_CLS_ROUTE help This option adds a `realm' match, which allows you to use the realm key from the routing subsystem inside iptables.