Patchwork XT_MATCH_REALM Kconfig whinge...

login
register
mail settings
Submitter Jan Engelhardt
Date Jan. 12, 2011, 8:57 p.m.
Message ID <alpine.LNX.2.01.1101122156310.27393@obet.zrqbmnf.qr>
Download mbox | patch
Permalink /patch/78614/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Jan Engelhardt - Jan. 12, 2011, 8:57 p.m.
On Wednesday 2011-01-12 20:48, Pablo Neira Ayuso wrote:

>On 12/01/11 20:15, Valdis.Kletnieks@vt.edu wrote:
>> scripts/kconfig/conf --silentoldconfig Kconfig
>> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED)
>> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED)
>
>Does this fix your problem?
>



This patch is not right. The select should just be removed, because
xt_realm is useful even without SCHED and CLS_ROUTE.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 1534f2b..ae56764 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -886,7 +886,8 @@  config NETFILTER_XT_MATCH_RATEEST
 config NETFILTER_XT_MATCH_REALM
 	tristate  '"realm" match support'
 	depends on NETFILTER_ADVANCED
-	select NET_CLS_ROUTE
+	depends on NET_SCHED
+	depends on NET_CLS_ROUTE
 	help
 	  This option adds a `realm' match, which allows you to use the realm
 	  key from the routing subsystem inside iptables.