Patchwork XT_MATCH_REALM Kconfig whinge...

login
register
mail settings
Submitter Pablo Neira
Date Jan. 12, 2011, 7:48 p.m.
Message ID <4D2E057D.30707@netfilter.org>
Download mbox | patch
Permalink /patch/78612/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Pablo Neira - Jan. 12, 2011, 7:48 p.m.
On 12/01/11 20:15, Valdis.Kletnieks@vt.edu wrote:
> scripts/kconfig/conf --silentoldconfig Kconfig
> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED)
> warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED)

Does this fix your problem?

Patch

netfilter: xt_realm: fix unmet direct dependencies

scripts/kconfig/conf --silentoldconfig Kconfig
warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED)
warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED)

Reported by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 1534f2b..ae56764 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -886,7 +886,8 @@  config NETFILTER_XT_MATCH_RATEEST
 config NETFILTER_XT_MATCH_REALM
 	tristate  '"realm" match support'
 	depends on NETFILTER_ADVANCED
-	select NET_CLS_ROUTE
+	depends on NET_SCHED
+	depends on NET_CLS_ROUTE
 	help
 	  This option adds a `realm' match, which allows you to use the realm
 	  key from the routing subsystem inside iptables.