| Message ID | 7567aa802cd3347aab19da6d4af6748f61e08f72.1499672630.git.arvind.yadav.cs@gmail.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 5894e3c..b2ddd5c 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -434,7 +434,7 @@ static ssize_t del_mux_store(struct device *d, struct device_attribute *attr, c NULL, }; -static struct attribute_group qmi_wwan_sysfs_attr_group = { +static const struct attribute_group qmi_wwan_sysfs_attr_group = { .name = "qmi", .attrs = qmi_wwan_sysfs_attrs, };
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/netdevice.h> work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 16831 464 0 17295 438f drivers/net/usb/qmi_wwan.o File size After adding 'const': text data bss dec hex filename 16895 400 0 17295 438f drivers/net/usb/qmi_wwan.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/net/usb/qmi_wwan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)