| Message ID | 20170710071615.k6b6726cwushhdmm@mwanda |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Jul 10, 2017 at 10:16:15AM +0300, Dan Carpenter wrote: > We're checking ptp_clock_register() for NULL but we should be checking > for error pointers. No. > diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c > index 50517cfd9671..c24313a103c6 100644 > --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c > +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c > @@ -441,7 +441,7 @@ void cxgb4_ptp_init(struct adapter *adapter) > > adapter->ptp_clock = ptp_clock_register(&adapter->ptp_clock_info, > &adapter->pdev->dev); > - if (!adapter->ptp_clock) { Yeah, that is wrong, but the fix is to check to IS_ERR or NULL. Thanks, Richard
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c index 50517cfd9671..c24313a103c6 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c @@ -441,7 +441,7 @@ void cxgb4_ptp_init(struct adapter *adapter) adapter->ptp_clock = ptp_clock_register(&adapter->ptp_clock_info, &adapter->pdev->dev); - if (!adapter->ptp_clock) { + if (IS_ERR(adapter->ptp_clock)) { dev_err(adapter->pdev_dev, "PTP %s Clock registration has failed\n", __func__); return;
We're checking ptp_clock_register() for NULL but we should be checking for error pointers. Fixes: 9c33e4208bce ("cxgb4: Add PTP Hardware Clock (PHC) support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>