From patchwork Wed Jan 12 11:20:14 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 78551 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B21D1B6F2B for ; Wed, 12 Jan 2011 23:12:31 +1100 (EST) Received: from localhost ([127.0.0.1]:57694 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PczYx-0006zb-1X for incoming@patchwork.ozlabs.org; Wed, 12 Jan 2011 07:12:27 -0500 Received: from [140.186.70.92] (port=56145 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pcyl6-0006Cb-C9 for qemu-devel@nongnu.org; Wed, 12 Jan 2011 06:20:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pcyl4-0001ba-23 for qemu-devel@nongnu.org; Wed, 12 Jan 2011 06:20:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pcyl3-0001bL-PR for qemu-devel@nongnu.org; Wed, 12 Jan 2011 06:20:54 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0CBKqGZ008315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Jan 2011 06:20:53 -0500 Received: from rincewind.home.kraxel.org (vpn2-8-125.ams2.redhat.com [10.36.8.125]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p0CBKjq9026814; Wed, 12 Jan 2011 06:20:47 -0500 Received: by rincewind.home.kraxel.org (Postfix, from userid 500) id 83EF641634; Wed, 12 Jan 2011 12:20:16 +0100 (CET) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Wed, 12 Jan 2011 12:20:14 +0100 Message-Id: <1294831214-4499-33-git-send-email-kraxel@redhat.com> In-Reply-To: <1294831214-4499-1-git-send-email-kraxel@redhat.com> References: <1294831214-4499-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Gerd Hoffmann Subject: [Qemu-devel] [PATCH v4 32/32] usb: zap pdev from usbport X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It isn't needed any more. Signed-off-by: Gerd Hoffmann --- hw/usb-bus.c | 3 +-- hw/usb-hub.c | 2 +- hw/usb-musb.c | 2 +- hw/usb-ohci.c | 2 +- hw/usb-uhci.c | 2 +- hw/usb.h | 3 +-- 6 files changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/usb-bus.c b/hw/usb-bus.c index f89176b..6e2e5fd 100644 --- a/hw/usb-bus.c +++ b/hw/usb-bus.c @@ -120,11 +120,10 @@ USBDevice *usb_create_simple(USBBus *bus, const char *name) } void usb_register_port(USBBus *bus, USBPort *port, void *opaque, int index, - USBDevice *pdev, USBPortOps *ops, int speedmask) + USBPortOps *ops, int speedmask) { port->opaque = opaque; port->index = index; - port->pdev = pdev; port->opaque = opaque; port->index = index; port->ops = ops; diff --git a/hw/usb-hub.c b/hw/usb-hub.c index 387c40c..78698ca 100644 --- a/hw/usb-hub.c +++ b/hw/usb-hub.c @@ -536,7 +536,7 @@ static int usb_hub_initfn(USBDevice *dev) for (i = 0; i < NUM_PORTS; i++) { port = &s->ports[i]; usb_register_port(usb_bus_from_device(dev), - &port->port, s, i, &s->dev, &usb_hub_port_ops, + &port->port, s, i, &usb_hub_port_ops, USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL); port->wPortStatus = PORT_STAT_POWER; port->wPortChange = 0; diff --git a/hw/usb-musb.c b/hw/usb-musb.c index 4b5f35b..782cfa2 100644 --- a/hw/usb-musb.c +++ b/hw/usb-musb.c @@ -349,7 +349,7 @@ struct MUSBState { } usb_bus_new(&s->bus, NULL /* FIXME */); - usb_register_port(&s->bus, &s->port, s, 0, NULL, &musb_port_ops, + usb_register_port(&s->bus, &s->port, s, 0, &musb_port_ops, USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL); usb_port_location(&s->port, NULL, 1); diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index 6344f81..09ea0b6 100644 --- a/hw/usb-ohci.c +++ b/hw/usb-ohci.c @@ -1699,7 +1699,7 @@ static void usb_ohci_init(OHCIState *ohci, DeviceState *dev, usb_bus_new(&ohci->bus, dev); ohci->num_ports = num_ports; for (i = 0; i < num_ports; i++) { - usb_register_port(&ohci->bus, &ohci->rhport[i].port, ohci, i, NULL, &ohci_port_ops, + usb_register_port(&ohci->bus, &ohci->rhport[i].port, ohci, i, &ohci_port_ops, USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL); usb_port_location(&ohci->rhport[i].port, NULL, i+1); } diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 6db1960..b384e1d 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -1129,7 +1129,7 @@ static int usb_uhci_common_initfn(UHCIState *s) usb_bus_new(&s->bus, &s->dev.qdev); for(i = 0; i < NB_PORTS; i++) { - usb_register_port(&s->bus, &s->ports[i].port, s, i, NULL, &uhci_port_ops, + usb_register_port(&s->bus, &s->ports[i].port, s, i, &uhci_port_ops, USB_SPEED_MASK_LOW | USB_SPEED_MASK_FULL); usb_port_location(&s->ports[i].port, NULL, i+1); } diff --git a/hw/usb.h b/hw/usb.h index c6e3e25..5c1da3e 100644 --- a/hw/usb.h +++ b/hw/usb.h @@ -244,7 +244,6 @@ struct USBPort { char path[16]; USBPortOps *ops; void *opaque; - USBDevice *pdev; int index; /* internal port index, may be used with the opaque */ QTAILQ_ENTRY(USBPort) next; }; @@ -355,7 +354,7 @@ USBDevice *usb_create(USBBus *bus, const char *name); USBDevice *usb_create_simple(USBBus *bus, const char *name); USBDevice *usbdevice_create(const char *cmdline); void usb_register_port(USBBus *bus, USBPort *port, void *opaque, int index, - USBDevice *pdev, USBPortOps *ops, int speedmask); + USBPortOps *ops, int speedmask); void usb_port_location(USBPort *downstream, USBPort *upstream, int portnr); void usb_unregister_port(USBBus *bus, USBPort *port); int usb_device_attach(USBDevice *dev);