| Message ID | 20170707002905.31111-1-jakub.kicinski@netronome.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Jakub Kicinski <jakub.kicinski@netronome.com> Date: Thu, 6 Jul 2017 17:29:05 -0700 > nfp_flower_metadata_cleanup() is defined but never invoked, > not calling it will cause us to leak mask and statistics > queue memory on the host. > > Fixes: 43f84b72c50d ("nfp: add metadata to each flow offload") > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Applied.
diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c b/drivers/net/ethernet/netronome/nfp/flower/main.c index fc10f27e0a0c..6a65c8b33807 100644 --- a/drivers/net/ethernet/netronome/nfp/flower/main.c +++ b/drivers/net/ethernet/netronome/nfp/flower/main.c @@ -356,6 +356,7 @@ static int nfp_flower_init(struct nfp_app *app) static void nfp_flower_clean(struct nfp_app *app) { + nfp_flower_metadata_cleanup(app); vfree(app->priv); app->priv = NULL; }
nfp_flower_metadata_cleanup() is defined but never invoked, not calling it will cause us to leak mask and statistics queue memory on the host. Fixes: 43f84b72c50d ("nfp: add metadata to each flow offload") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/main.c | 1 + 1 file changed, 1 insertion(+)