| Message ID | 20170706205849.22298-1-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
On 06-07-17 22:58, Thomas Petazzoni wrote: > Building the MTD test programs requires the MS_DIRSYNC, which is not > necessarily available on old build machines. But obviously, MTD test > programs are not needed, so we can simply disable them, as they were > prior to the migration to mtd 2.0. > > Fixes: > > http://autobuild.buildroot.net/results/21e1ad2a4560b6d3ba6490d20ae064246e66d5c1/ > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > --- > package/mtd/mtd.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk > index 7c3a2b6..043f1c7 100644 > --- a/package/mtd/mtd.mk > +++ b/package/mtd/mtd.mk > @@ -45,6 +45,7 @@ MTD_CONF_OPTS += --without-xattr > endif > > HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-e2fsprogs > +HOST_MTD_CONF_OPTS = --disable-tests > > MKFS_JFFS2 = $(HOST_DIR)/sbin/mkfs.jffs2 > SUMTOOL = $(HOST_DIR)/sbin/sumtool >
Hello, On Thu, 6 Jul 2017 22:58:47 +0200, Thomas Petazzoni wrote: > Building the MTD test programs requires the MS_DIRSYNC, which is not > necessarily available on old build machines. But obviously, MTD test > programs are not needed, so we can simply disable them, as they were > prior to the migration to mtd 2.0. > > Fixes: > > http://autobuild.buildroot.net/results/21e1ad2a4560b6d3ba6490d20ae064246e66d5c1/ > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > package/mtd/mtd.mk | 1 + > 1 file changed, 1 insertion(+) Patches 1 and 2 applied. Thanks Arnout for the review. Thomas
On 07-07-17 10:02, Thomas Petazzoni wrote: > Hello, > > On Thu, 6 Jul 2017 22:58:47 +0200, Thomas Petazzoni wrote: >> Building the MTD test programs requires the MS_DIRSYNC, which is not >> necessarily available on old build machines. But obviously, MTD test >> programs are not needed, so we can simply disable them, as they were >> prior to the migration to mtd 2.0. >> >> Fixes: >> >> http://autobuild.buildroot.net/results/21e1ad2a4560b6d3ba6490d20ae064246e66d5c1/ >> >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> --- >> package/mtd/mtd.mk | 1 + >> 1 file changed, 1 insertion(+) > > Patches 1 and 2 applied. Thanks Arnout for the review. Unfortunately you missed Baruch's comment... Regards, Arnout
Hello, On Fri, 7 Jul 2017 10:21:36 +0200, Arnout Vandecappelle wrote: > > Patches 1 and 2 applied. Thanks Arnout for the review. > > Unfortunately you missed Baruch's comment... Dammit :-/ And still, I did notice and fixed a mistake that neither you nor Baruch spotted: """ So today, the target variant continues to depend on util-linux, while the target variant depends on e2fsprogs. """ Obviously the second "target variant" should have been "host variant", and I fixed that before pushing. Thomas
diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk index 7c3a2b6..043f1c7 100644 --- a/package/mtd/mtd.mk +++ b/package/mtd/mtd.mk @@ -45,6 +45,7 @@ MTD_CONF_OPTS += --without-xattr endif HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-e2fsprogs +HOST_MTD_CONF_OPTS = --disable-tests MKFS_JFFS2 = $(HOST_DIR)/sbin/mkfs.jffs2 SUMTOOL = $(HOST_DIR)/sbin/sumtool
Building the MTD test programs requires the MS_DIRSYNC, which is not necessarily available on old build machines. But obviously, MTD test programs are not needed, so we can simply disable them, as they were prior to the migration to mtd 2.0. Fixes: http://autobuild.buildroot.net/results/21e1ad2a4560b6d3ba6490d20ae064246e66d5c1/ Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/mtd/mtd.mk | 1 + 1 file changed, 1 insertion(+)