| Message ID | 20170706205849.22298-3-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Superseded |
| Headers | show |
On 06-07-17 22:58, Thomas Petazzoni wrote: > Instead of letting auto-detection do its job, be explicit about the > fact that we want the JFFS2 and UBIFS utilities when building the host > variant of mtd. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > package/mtd/mtd.mk | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk > index 3bac2d5..807f559 100644 > --- a/package/mtd/mtd.mk > +++ b/package/mtd/mtd.mk > @@ -45,7 +45,10 @@ MTD_CONF_OPTS += --without-xattr > endif > > HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux > -HOST_MTD_CONF_OPTS = --disable-tests > +HOST_MTD_CONF_OPTS = \ > + --with-jffs \ > + --with-ubifs \ If you do this, it would also seem natural to add --without-xattr --with-lzo (although we probably want xattr support in ubifs images, at least if BR2_ROOTFS_DEVICE_TABLE_SUPPORTS_EXTENDED_ATTRIBUTES is set, but that's for another day :-). Regards, Arnout > + --disable-tests > > MKFS_JFFS2 = $(HOST_DIR)/sbin/mkfs.jffs2 > SUMTOOL = $(HOST_DIR)/sbin/sumtool >
Hello, On Fri, 7 Jul 2017 00:57:59 +0200, Arnout Vandecappelle wrote: > On 06-07-17 22:58, Thomas Petazzoni wrote: > > Instead of letting auto-detection do its job, be explicit about the > > fact that we want the JFFS2 and UBIFS utilities when building the host > > variant of mtd. > > > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > --- > > package/mtd/mtd.mk | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk > > index 3bac2d5..807f559 100644 > > --- a/package/mtd/mtd.mk > > +++ b/package/mtd/mtd.mk > > @@ -45,7 +45,10 @@ MTD_CONF_OPTS += --without-xattr > > endif > > > > HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux > > -HOST_MTD_CONF_OPTS = --disable-tests > > +HOST_MTD_CONF_OPTS = \ > > + --with-jffs \ > > + --with-ubifs \ > > If you do this, it would also seem natural to add > > --without-xattr --with-lzo Indeed for --without-xattr. However, we don't pass --with-lzo/--without-lzo for the target variant. Perhaps we should as well. Thomas
diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk index 3bac2d5..807f559 100644 --- a/package/mtd/mtd.mk +++ b/package/mtd/mtd.mk @@ -45,7 +45,10 @@ MTD_CONF_OPTS += --without-xattr endif HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux -HOST_MTD_CONF_OPTS = --disable-tests +HOST_MTD_CONF_OPTS = \ + --with-jffs \ + --with-ubifs \ + --disable-tests MKFS_JFFS2 = $(HOST_DIR)/sbin/mkfs.jffs2 SUMTOOL = $(HOST_DIR)/sbin/sumtool
Instead of letting auto-detection do its job, be explicit about the fact that we want the JFFS2 and UBIFS utilities when building the host variant of mtd. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/mtd/mtd.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)