diff mbox

[linux,dev-4.10,4/4] ARM: dts: cfam: Fix hub node

Message ID 20170706143503.21888-5-joel@jms.id.au
State Rejected, archived
Headers show

Commit Message

Joel Stanley July 6, 2017, 2:35 p.m. UTC
The hub node was not being probed as it had malformed address-cells and
size-cells nodes.

This fixes probing of i2c devices on the first (non-hub) P9 socket.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 arch/arm/boot/dts/ibm-power9-cfam.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Eddie James July 6, 2017, 7:50 p.m. UTC | #1
On 07/06/2017 09:35 AM, Joel Stanley wrote:
> The hub node was not being probed as it had malformed address-cells and
> size-cells nodes.
>
> This fixes probing of i2c devices on the first (non-hub) P9 socket.

I can't replicate the problem you were having with the original or my 
modified device tree. All FSI devices
are probing fine for me. I don't think we should merge this.

Thanks,
Eddie

>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>   arch/arm/boot/dts/ibm-power9-cfam.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ibm-power9-cfam.dtsi b/arch/arm/boot/dts/ibm-power9-cfam.dtsi
> index 669ed6804f74..16802933558e 100644
> --- a/arch/arm/boot/dts/ibm-power9-cfam.dtsi
> +++ b/arch/arm/boot/dts/ibm-power9-cfam.dtsi
> @@ -1,8 +1,8 @@
>   &fsi {
>   	cfam@0,0 {
>   		reg = <0 0>;
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> +		#address-cells = <2>;
> +		#size-cells = <0>;
>
>   		i2c@1800 {
>   			compatible = "ibm,fsi-i2c-master";
diff mbox

Patch

diff --git a/arch/arm/boot/dts/ibm-power9-cfam.dtsi b/arch/arm/boot/dts/ibm-power9-cfam.dtsi
index 669ed6804f74..16802933558e 100644
--- a/arch/arm/boot/dts/ibm-power9-cfam.dtsi
+++ b/arch/arm/boot/dts/ibm-power9-cfam.dtsi
@@ -1,8 +1,8 @@ 
 &fsi {
 	cfam@0,0 {
 		reg = <0 0>;
-		#address-cells = <1>;
-		#size-cells = <1>;
+		#address-cells = <2>;
+		#size-cells = <0>;
 
 		i2c@1800 {
 			compatible = "ibm,fsi-i2c-master";