diff mbox

[linux,dev-4.10,3/4] i2c: fsi: Remove idx counter

Message ID 20170706143503.21888-4-joel@jms.id.au
State Accepted, archived
Headers show

Commit Message

Joel Stanley July 6, 2017, 2:35 p.m. UTC
It is no longer used.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 drivers/i2c/busses/i2c-fsi.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Eddie James July 7, 2017, 8:04 p.m. UTC | #1
On 07/06/2017 09:35 AM, Joel Stanley wrote:
> It is no longer used.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Thanks!

Acked-by: Eddie James <eajames@linux.vnet.ibm.com>

> ---
>   drivers/i2c/busses/i2c-fsi.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c
> index 349bea0e2a63..0c7efb667427 100644
> --- a/drivers/i2c/busses/i2c-fsi.c
> +++ b/drivers/i2c/busses/i2c-fsi.c
> @@ -132,7 +132,6 @@
>
>   struct fsi_i2c_master {
>   	struct fsi_device	*fsi;
> -	int			idx;
>   	u8			fifo_size;
>   	struct list_head	ports;
>   	wait_queue_head_t	wait;
> @@ -147,8 +146,6 @@ struct fsi_i2c_port {
>   	u16			xfrd;
>   };
>
> -static DEFINE_IDA(fsi_i2c_ida);
> -
>   static int fsi_i2c_read_reg(struct fsi_device *fsi, unsigned int reg,
>   			    u32 *data)
>   {
> @@ -563,7 +560,6 @@ static int fsi_i2c_probe(struct device *dev)
>   	init_waitqueue_head(&i2c->wait);
>   	sema_init(&i2c->lock, 1);
>   	i2c->fsi = to_fsi_dev(dev);
> -	i2c->idx = ida_simple_get(&fsi_i2c_ida, 1, INT_MAX, GFP_KERNEL);
>   	INIT_LIST_HEAD(&i2c->ports);
>
>   	/* add adapter for each i2c port of the master */
> @@ -613,8 +609,6 @@ static int fsi_i2c_remove(struct device *dev)
>   		i2c_del_adapter(&port->adapter);
>   	}
>
> -	ida_simple_remove(&fsi_i2c_ida, i2c->idx);
> -
>   	return 0;
>   }
>
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-fsi.c b/drivers/i2c/busses/i2c-fsi.c
index 349bea0e2a63..0c7efb667427 100644
--- a/drivers/i2c/busses/i2c-fsi.c
+++ b/drivers/i2c/busses/i2c-fsi.c
@@ -132,7 +132,6 @@ 
 
 struct fsi_i2c_master {
 	struct fsi_device	*fsi;
-	int			idx;
 	u8			fifo_size;
 	struct list_head	ports;
 	wait_queue_head_t	wait;
@@ -147,8 +146,6 @@  struct fsi_i2c_port {
 	u16			xfrd;
 };
 
-static DEFINE_IDA(fsi_i2c_ida);
-
 static int fsi_i2c_read_reg(struct fsi_device *fsi, unsigned int reg,
 			    u32 *data)
 {
@@ -563,7 +560,6 @@  static int fsi_i2c_probe(struct device *dev)
 	init_waitqueue_head(&i2c->wait);
 	sema_init(&i2c->lock, 1);
 	i2c->fsi = to_fsi_dev(dev);
-	i2c->idx = ida_simple_get(&fsi_i2c_ida, 1, INT_MAX, GFP_KERNEL);
 	INIT_LIST_HEAD(&i2c->ports);
 
 	/* add adapter for each i2c port of the master */
@@ -613,8 +609,6 @@  static int fsi_i2c_remove(struct device *dev)
 		i2c_del_adapter(&port->adapter);
 	}
 
-	ida_simple_remove(&fsi_i2c_ida, i2c->idx);
-
 	return 0;
 }