[3/3] dt-bindings: i2c: eeprom: document "mac-offset" binding

Message ID 1499336217-16913-4-git-send-email-claudiu.beznea@microchip.com
State New
Headers show

Commit Message

Claudiu Beznea July 6, 2017, 10:16 a.m.
Document "mac-offset" binding that will be used by at24 EEPROM driver.

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 Documentation/devicetree/bindings/eeprom/eeprom.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Rob Herring July 10, 2017, 3:46 a.m. | #1
On Thu, Jul 06, 2017 at 01:16:57PM +0300, Claudiu Beznea wrote:
> Document "mac-offset" binding that will be used by at24 EEPROM driver.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> index a50dc01..3dd267c 100644
> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
> @@ -35,10 +35,13 @@ Optional properties:
>  
>    - read-only: this parameterless property disables writes to the eeprom
>  
> +  - mac-offset: offset in EEPROM where MAC address starts
> +

This doesn't scale if you have multiple things you need the offset to, 
and we already have a binding for this. Use the nvmem binding.

Rob
Claudiu Beznea July 19, 2017, 9:08 a.m. | #2
On 10.07.2017 06:46, Rob Herring wrote:
> On Thu, Jul 06, 2017 at 01:16:57PM +0300, Claudiu Beznea wrote:
>> Document "mac-offset" binding that will be used by at24 EEPROM driver.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>>  Documentation/devicetree/bindings/eeprom/eeprom.txt | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
>> index a50dc01..3dd267c 100644
>> --- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
>> +++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
>> @@ -35,10 +35,13 @@ Optional properties:
>>  
>>    - read-only: this parameterless property disables writes to the eeprom
>>  
>> +  - mac-offset: offset in EEPROM where MAC address starts
>> +
> 
> This doesn't scale if you have multiple things you need the offset to, 
> and we already have a binding for this. Use the nvmem binding.
Are you talking about nvmem-cells, nvmem-cell-names bindings? Since
at24 is i2c driver, I can only think at it as a nvmem provider. Using these
bindings it will imply, as per my understanding about nvmem subsystem, that
this should also become a nvmem consumer. It looks a little strange to
me but I don't have deep knowledge about subsystem, correct me if I'm wrong.
Please let me know if you are talking about using these bindings and reading
them (just to get the offset passed in "reg" binding) by not passing the nvmem
APIs defined in nvmem core.

Thank you,
Claudiu
> 
> Rob
>

Patch

diff --git a/Documentation/devicetree/bindings/eeprom/eeprom.txt b/Documentation/devicetree/bindings/eeprom/eeprom.txt
index a50dc01..3dd267c 100644
--- a/Documentation/devicetree/bindings/eeprom/eeprom.txt
+++ b/Documentation/devicetree/bindings/eeprom/eeprom.txt
@@ -35,10 +35,13 @@  Optional properties:
 
   - read-only: this parameterless property disables writes to the eeprom
 
+  - mac-offset: offset in EEPROM where MAC address starts
+
 Example:
 
 eeprom@52 {
 	compatible = "atmel,24c32";
 	reg = <0x52>;
 	pagesize = <32>;
+	mac-offset = <0xf8>;
 };