Patchwork [3/9] powerpc: Never halt RTAS error logging after receiving an unrecoverable machine check

login
register
mail settings
Submitter Anton Blanchard
Date Jan. 12, 2011, 5:46 a.m.
Message ID <20110112164629.47585ca9@kryten>
Download mbox | patch
Permalink /patch/78506/
State Accepted
Commit 3f9793e6b66efcf196974ee4f0d62de6282eb41b
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Anton Blanchard - Jan. 12, 2011, 5:46 a.m.
Newer versions of the System p firwmare send a partial RTAS error log in the
machine check handler with a more detailed response appearing sometime later
via check event.

This means at machine check time we do not have enough information to
ascertain exactly what went on. Furthermore, I have found the RTAS error
logs in the machine check handler contain no useful information, so halting on
them makes little sense. If we want to halt it would make more sense to do
it following the error log received sometime later via check event.

In light of this, never halt the error log in the pseries machine
check handler.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

Patch

Index: powerpc.git/arch/powerpc/platforms/pseries/ras.c
===================================================================
--- powerpc.git.orig/arch/powerpc/platforms/pseries/ras.c	2010-09-27 21:19:32.805480948 +1000
+++ powerpc.git/arch/powerpc/platforms/pseries/ras.c	2010-10-15 13:23:34.161268941 +1100
@@ -281,7 +281,7 @@  static int recover_mce(struct pt_regs *r
 		nonfatal = 1;
 	}
 
-	log_error((char *)err, ERR_TYPE_RTAS_LOG, !nonfatal);
+	log_error((char *)err, ERR_TYPE_RTAS_LOG, 0);
 
 	return nonfatal;
 }