| Message ID | 1866436784.1311518.1499303988299@poczta.nazwa.pl |
|---|---|
| State | New |
| Headers | show |
Rafal Luzynski <digitalfreak@lingonborough.com> wrote: > This is the second and hopefully correct version of the patch sent on > Jul 1. [1] Looks good except for one problem: > diff --git a/localedata/locales/ar_IQ b/localedata/locales/ar_IQ > index f128293..ac0f50e 100644 > --- a/localedata/locales/ar_IQ > +++ b/localedata/locales/ar_IQ > @@ -105,12 +105,18 @@ day "الأحد";/ > "السبت" > % > % Abbreviated month names (%b) > -abmon "ينا";"فبر";/ > - "مار";"أبر";/ > - "ماي";"يون";/ > - "يول";"أغس";/ > - "سبت";"أكت";/ > - "نوف";"ديس" > +abmon "كانون الثاني";/ > + "شباط";/ > + "آذار";/ > + "نيسان";/ > + "أيار";/ > + "حزيران";/ > + "تموز";/ > + "آب";/ > + "أيلول";/ > + "تشرین الأول";/ The 4th code point in that translation for "October" is U+06CC ARABIC LETTER FARSI YEH. It cannot be converted to ISO-8859-6, therefore the build of the ar_IQ.ISO-8859-6 locale fails: ar_IQ.ISO-8859-6...locales/ar_IQ:117: LC_TIME: unknown character in field `abmon' I think that is a bug in CLDR and reported http://unicode.org/cldr/trac/ticket/10460 > + "تشرين الثاني";/ > + "كانون الأول" > % > % Full month names (%B) > mon "كانون الثاني";/
Mike FABIAN <mfabian@redhat.com> wrote: > Rafal Luzynski <digitalfreak@lingonborough.com> wrote: > >> This is the second and hopefully correct version of the patch sent on >> Jul 1. [1] > > Looks good except for one problem: [...] > I think that is a bug in CLDR and reported > > http://unicode.org/cldr/trac/ticket/10460 I’ve fixed that in your patch and committed your patch now.
6.07.2017 15:53 Mike FABIAN <mfabian@redhat.com> wrote: > > > Mike FABIAN <mfabian@redhat.com> wrote: > > > Rafal Luzynski <digitalfreak@lingonborough.com> wrote: > > > >> This is the second and hopefully correct version of the patch sent on > >> Jul 1. [1] > > > > Looks good except for one problem: > > [...] > > > I think that is a bug in CLDR and reported > > > > http://unicode.org/cldr/trac/ticket/10460 > > I’ve fixed that in your patch and committed your patch now. Thank you for the fix and for the commit. Rafal
diff --git a/localedata/locales/ar_DZ b/localedata/locales/ar_DZ index 4789ff5..fa01c71 100644 --- a/localedata/locales/ar_DZ +++ b/localedata/locales/ar_DZ @@ -105,12 +105,18 @@ day "الأحد";/ "السبت" % % Abbreviated month names (%b) -abmon "ينا";"فبر";/ - "مار";"أبر";/ - "ماي";"يون";/ - "يول";"أغس";/ - "سبت";"أكت";/ - "نوف";"ديس" +abmon "جانفي";/ + "فيفري";/ + "مارس";/ + "أفريل";/ + "ماي";/ + "جوان";/ + "جويلية";/ + "أوت";/ + "سبتمبر";/ + "أكتوبر";/ + "نوفمبر";/ + "ديسمبر" % % Full month names (%B) mon "جانفي";/ diff --git a/localedata/locales/ar_IQ b/localedata/locales/ar_IQ index f128293..ac0f50e 100644 --- a/localedata/locales/ar_IQ +++ b/localedata/locales/ar_IQ @@ -105,12 +105,18 @@ day "الأحد";/ "السبت" % % Abbreviated month names (%b) -abmon "ينا";"فبر";/ - "مار";"أبر";/ - "ماي";"يون";/ - "يول";"أغس";/ - "سبت";"أكت";/ - "نوف";"ديس" +abmon "كانون الثاني";/ + "شباط";/ + "آذار";/ + "نيسان";/ + "أيار";/ + "حزيران";/ + "تموز";/ + "آب";/ + "أيلول";/ + "تشرین الأول";/ + "تشرين الثاني";/ + "كانون الأول" % % Full month names (%B) mon "كانون الثاني";/ diff --git a/localedata/locales/ar_JO b/localedata/locales/ar_JO index 9bac497..13b32fd 100644 --- a/localedata/locales/ar_JO +++ b/localedata/locales/ar_JO @@ -114,7 +114,7 @@ abmon "كانون ال/ "شباط";/ "آذار";/ "نيسان";/ - "نوار";/ + "أيار";/ "حزيران";/ "تموز";/ "آب";/ diff --git a/localedata/locales/ar_LB b/localedata/locales/ar_LB index 2e22767..1cb6b25 100644 --- a/localedata/locales/ar_LB +++ b/localedata/locales/ar_LB @@ -113,7 +113,7 @@ abmon "كانون ال/ "شباط";/ "آذار";/ "نيسان";/ - "نوار";/ + "أيار";/ "حزيران";/ "تموز";/ "آب";/ diff --git a/localedata/locales/ar_MA b/localedata/locales/ar_MA index a157d97..081e6cb 100644 --- a/localedata/locales/ar_MA +++ b/localedata/locales/ar_MA @@ -105,12 +105,18 @@ day "الأحد";/ "السبت" % % Abbreviated month names (%b) -abmon "ينا";"فبر";/ - "مار";"أبر";/ - "ماي";"يون";/ - "يول";"أغس";/ - "سبت";"أكت";/ - "نوف";"ديس" +abmon "يناير";/ + "فبراير";/ + "مارس";/ + "أبريل";/ + "ماي";/ + "يونيو";/ + "يوليوز";/ + "غشت";/ + "شتنبر";/ + "أكتوبر";/ + "نونبر";/ + "دجنبر" % % Full month names (%B) mon "يناير";/ diff --git a/localedata/locales/ar_SA b/localedata/locales/ar_SA index 88698ff..420e748 100644 --- a/localedata/locales/ar_SA +++ b/localedata/locales/ar_SA @@ -335,18 +335,18 @@ mon "يناير";/ "أكتوبر";/ "نوفمبر";/ "ديسمبر" -abmon "Jan"; / - "Feb"; / - "Mar"; / - "Apr"; / - "May"; / - "Jun"; / - "Jul"; / - "Aug"; / - "Sep"; / - "Oct"; / - "Nov"; / - "Dec" +abmon "يناير";/ + "فبراير";/ + "مارس";/ + "أبريل";/ + "مايو";/ + "يونيو";/ + "يوليو";/ + "أغسطس";/ + "سبتمبر";/ + "أكتوبر";/ + "نوفمبر";/ + "ديسمبر" am_pm "";"" era_d_fmt "" week 7;19971130;1 diff --git a/localedata/locales/ar_SY b/localedata/locales/ar_SY index 9cc7ce5..56ed144 100644 --- a/localedata/locales/ar_SY +++ b/localedata/locales/ar_SY @@ -113,7 +113,7 @@ abmon "كانون ال/ "شباط";/ "آذار";/ "نيسان";/ - "نوار";/ + "أيار";/ "حزيران";/ "تموز";/ "آب";/ diff --git a/localedata/locales/ar_TN b/localedata/locales/ar_TN index e277275..671b0ce 100644 --- a/localedata/locales/ar_TN +++ b/localedata/locales/ar_TN @@ -105,12 +105,18 @@ day "الأحد";/ "السبت" % % Abbreviated month names (%b) -abmon "ينا";"فبر";/ - "مار";"أبر";/ - "ماي";"يون";/ - "يول";"أغس";/ - "سبت";"أكت";/ - "نوف";"ديس" +abmon "جانفي";/ + "فيفري";/ + "مارس";/ + "أفريل";/ + "ماي";/ + "جوان";/ + "جويلية";/ + "أوت";/ + "سبتمبر";/ + "أكتوبر";/ + "نوفمبر";/ + "ديسمبر" % % Full month names (%B) mon "جانفي";/ diff --git a/localedata/locales/ks_IN b/localedata/locales/ks_IN index 320258b..094f2cd 100644 --- a/localedata/locales/ks_IN +++ b/localedata/locales/ks_IN @@ -110,18 +110,18 @@ day "آتهوار";/ "جمع";"بٹوار" % % Abbreviated month names (%b) -abmon "جنوری";/ - "فروری";/ - "مارچ";/ +abmon "جنؤری";/ + "فرؤری";/ + "مارٕچ";/ "اپریل";/ - "مئ";/ - "جون";/ - "جُلئ";/ + "میٔ";/ + "جوٗن";/ + "جوٗلایی";/ "اگست";/ - "ستنبر";/ - "اکتوبر";/ - "نوںبر";/ - "دسنبر" + "ستمبر";/ + "اکتوٗبر";/ + "نومبر";/ + "دسمبر" % % Full month names (%B) mon "جنؤری";/ diff --git a/localedata/locales/ps_AF b/localedata/locales/ps_AF index 2900819..49e1e73 100644 --- a/localedata/locales/ps_AF +++ b/localedata/locales/ps_AF @@ -164,23 +164,23 @@ day "یکشنبه";/ "پنجشنبه";/ "جمعه";/ "شنبه" -abmon "جنو";/ - "فبر";/ - "مار";/ - "اپر";/ - "مـې";/ +abmon "جنوري";/ + "فبروري";/ + "مارچ";/ + "اپریل";/ + "مۍ";/ "جون";/ - "جول";/ - "اګس";/ - "سپت";/ - "اکت";/ - "نوم";/ - "دسم" + "جولای";/ + "اګست";/ + "سپتمبر";/ + "اکتوبر";/ + "نومبر";/ + "دسمبر" mon "جنوري";/ "فبروري";/ "مارچ";/ "اپریل";/ - "می";/ + "مۍ";/ "جون";/ "جولای";/ "اګست";/ diff --git a/localedata/locales/ug_CN b/localedata/locales/ug_CN index 205f4b0..3773176 100644 --- a/localedata/locales/ug_CN +++ b/localedata/locales/ug_CN @@ -250,18 +250,18 @@ day "يەكشەنبە";/ "پەيشەنبە";/ "جۈمە";/ "شەنبە" -abmon "قەھرىتان";/ - "ھۇت";/ - "نورۇز";/ - "ئۈمىد";/ - "باھار";/ - "سەپەر";/ - "چىللە";/ - "تومۇز";/ - "مىزان";/ - "ئوغۇز";/ - "ئوغلاق";/ - "كۆنەك" +abmon "يانۋار";/ + "فېۋرال";/ + "مارت";/ + "ئاپرېل";/ + "ماي";/ + "ئىيۇن";/ + "ئىيۇل";/ + "ئاۋغۇست";/ + "سېنتەبىر";/ + "ئۆكتەبىر";/ + "نويابىر";/ + "دېكابىر" mon "يانۋار";/ "فېۋرال";/ "مارت";/ diff --git a/localedata/locales/ur_IN b/localedata/locales/ur_IN index 4b4309c..1af10ed 100644 --- a/localedata/locales/ur_IN +++ b/localedata/locales/ur_IN @@ -99,7 +99,7 @@ abmon "جنوری";/ "جولائی";/ "اگست";/ "ستمبر";/ - "اكتوبر";/ + "اکتوبر";/ "نومبر";/ "دسمبر" % diff --git a/localedata/locales/ur_PK b/localedata/locales/ur_PK index 2281ef5..c9fcd19 100644 --- a/localedata/locales/ur_PK +++ b/localedata/locales/ur_PK @@ -111,16 +111,16 @@ day "اتوار";/ "جمعرات";/ "جمعه";/ "هفته" -abmon "جنوري";/ - "فروري";/ +abmon "جنوری";/ + "فروری";/ "مارچ";/ - "اپريل";/ - "مٓی";/ + "اپریل";/ + "مئی";/ "جون";/ - "جولاي";/ + "جولائی";/ "اگست";/ "ستمبر";/ - "اكتوبر";/ + "اکتوبر";/ "نومبر";/ "دسمبر" mon "جنوری";/
This is the second and hopefully correct version of the patch sent on Jul 1. [1] Should I ask for the freeze break exception? If yes then here I ask. Please treat this patch as a fix for the bugs introduced by incomplete or simply wrong patch fixing mon (full month names) array for the languages using the Arabic script. [2] Changes introduced in this version: * ar_DZ, ar_MA, ar_TN: I no longer try to construct the abbreviated forms, abmon is now a direct import from CLDR and contains the same as mon. * ar_IQ: also imported, same as above. But I still suspect the content is not correct. All abbreviated and full are the same, respectively but October full is: "<U062A><U0634><U0631><U064A><U0646><U0020><U0627><U0644><U0623><U0648><U0644>" ("تشرين الأول") while abbreviated: "<U062A><U0634><U0631><U06CC><U0646><U0020><U0627><U0644><U0623><U0648><U0644>". ("تشرین الأول"). This must be a bug in CLDR because it says the same. It's been said many times in the past that we should follow CLDR and if there are bugs then let them be fixed first. * ps_AF: likewise, abmon array is fully imported and no longer contains the abbreviated forms. But the new import revealed that also the full name of May has been changed in CLDR. I'm sorry for all the troubles. Regards, Rafal [1] https://sourceware.org/ml/libc-alpha/2017-07/msg00001.html [2] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=c853f14 -------- Here is a decoded version of the patch explaining the changes: