diff mbox

[v7,6/9] core: install relocation script and location at the end of the build

Message ID 1499273594-12106-7-git-send-email-wg@grandegger.com
State Superseded
Headers show

Commit Message

Wolfgang Grandegger July 5, 2017, 4:53 p.m. UTC
The script "relocate-sdk.sh" is installed into the top directory of
the SDK (HOST_DIR) and the SDK location path is stored in the file
"HOST_DIR/share/buildroot/sdk-location"-

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
 Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Arnout Vandecappelle July 19, 2017, 11:58 p.m. UTC | #1
On 05-07-17 18:53, Wolfgang Grandegger wrote:
> The script "relocate-sdk.sh" is installed into the top directory of
> the SDK (HOST_DIR) and the SDK location path is stored in the file
> "HOST_DIR/share/buildroot/sdk-location"-
> 
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 However, while testing this I noticed a problem in relocate-sdk.sh: it uses a
bashism on line 43: < <(...) but the shebang is /bin/sh. I think the best
solution is to convert it into a normal pipe, since there is no real reason
there to use the < <(...) construct.

 Regards,
 Arnout

> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 2a265e0..32f85e8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -559,6 +559,8 @@ world: target-post-image host-finalize
>  host-finalize:
>  	@$(call MESSAGE,"Rendering the SDK relocatable")
>  	$(TOPDIR)/support/scripts/fix-rpath host
> +	install $(TOPDIR)/support/misc/relocate-sdk.sh $(HOST_DIR)
> +	echo $(HOST_DIR) > $(HOST_DIR)/share/buildroot/sdk-location
>  
>  # When creating HOST_DIR, also symlink usr -> .
>  $(HOST_DIR):
>
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 2a265e0..32f85e8 100644
--- a/Makefile
+++ b/Makefile
@@ -559,6 +559,8 @@  world: target-post-image host-finalize
 host-finalize:
 	@$(call MESSAGE,"Rendering the SDK relocatable")
 	$(TOPDIR)/support/scripts/fix-rpath host
+	install $(TOPDIR)/support/misc/relocate-sdk.sh $(HOST_DIR)
+	echo $(HOST_DIR) > $(HOST_DIR)/share/buildroot/sdk-location
 
 # When creating HOST_DIR, also symlink usr -> .
 $(HOST_DIR):