Message ID | 20170705130100.441-2-s.martin49@gmail.com |
---|---|
State | Superseded |
Headers | show |
Hi Samuel, On Wed, Jul 05, 2017 at 03:01:00PM +0200, Samuel Martin wrote: > + The default is "-O ^64bit", i.e. disable the 64-bit filesystem. > + This is chosen because U-Boot versions before 2017.02 don't > + support that filesystem option, which may render the system > + unbootable if it is used. Maybe also mention that this option is only useful for 2TB+ filesystems. baruch
Baruch, All, On 2017-07-05 16:09 +0300, Baruch Siach spake thusly: > Hi Samuel, > > On Wed, Jul 05, 2017 at 03:01:00PM +0200, Samuel Martin wrote: > > + The default is "-O ^64bit", i.e. disable the 64-bit filesystem. > > + This is chosen because U-Boot versions before 2017.02 don't > > + support that filesystem option, which may render the system > > + unbootable if it is used. > > Maybe also mention that this option is only useful for 2TB+ filesystems. As Sébastien said, this is no longer true since release 1.43: http://lists.busybox.net/pipermail/buildroot/2017-July/197007.html Regards, Yann E. MORIN.
Hi Yann, On Wed, Jul 05, 2017 at 03:13:39PM +0200, Yann E. MORIN wrote: > On 2017-07-05 16:09 +0300, Baruch Siach spake thusly: > > On Wed, Jul 05, 2017 at 03:01:00PM +0200, Samuel Martin wrote: > > > + The default is "-O ^64bit", i.e. disable the 64-bit filesystem. > > > + This is chosen because U-Boot versions before 2017.02 don't > > > + support that filesystem option, which may render the system > > > + unbootable if it is used. > > > > Maybe also mention that this option is only useful for 2TB+ filesystems. > > As Sébastien said, this is no longer true since release 1.43: > http://lists.busybox.net/pipermail/buildroot/2017-July/197007.html As far as I can see Sébastien only said that 64bit is enabled by default since 1.43. That does not mean that the 64bit feature is useful for smaller (and much more common) filesystems. baruch
diff --git a/fs/ext2/Config.in b/fs/ext2/Config.in index aeee91748..5aec21078 100644 --- a/fs/ext2/Config.in +++ b/fs/ext2/Config.in @@ -67,6 +67,24 @@ config BR2_TARGET_ROOTFS_EXT2_RESBLKS Traditionally, this has been 5%, and all ext-related tools still default to reserving 5% when creating a new ext filesystem. +config BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS + string "additional mke2fs options" + default "-O ^64bit" + help + Specify a space-separated list of mke2fs options, including any + ext2/3/4 filesystem features. + + For more information about the mke2fs option, see the manual + page mke2fs(8). + + For more information about the ext2/3/4 features which can be + set, see then manual page ext4(5). + + The default is "-O ^64bit", i.e. disable the 64-bit filesystem. + This is chosen because U-Boot versions before 2017.02 don't + support that filesystem option, which may render the system + unbootable if it is used. + choice prompt "Compression method" default BR2_TARGET_ROOTFS_EXT2_NONE diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk index b609d36ae..06970f0ee 100644 --- a/fs/ext2/ext2.mk +++ b/fs/ext2/ext2.mk @@ -9,6 +9,8 @@ ifeq ($(BR2_TARGET_ROOTFS_EXT2)-$(EXT2_SIZE),y-) $(error BR2_TARGET_ROOTFS_EXT2_SIZE cannot be empty) endif +EXT2_MKFS_OPTS = $(call qstrip,$(BR2_TARGET_ROOTFS_EXT2_MKFS_OPTIONS)) + # qstrip results in stripping consecutive spaces into a single one. So the # variable is not qstrip-ed to preserve the integrity of the string value. EXT2_LABEL := $(subst ",,$(BR2_TARGET_ROOTFS_EXT2_LABEL)) @@ -19,7 +21,8 @@ EXT2_OPTS = \ -r $(BR2_TARGET_ROOTFS_EXT2_REV) \ -N $(BR2_TARGET_ROOTFS_EXT2_INODES) \ -m $(BR2_TARGET_ROOTFS_EXT2_RESBLKS) \ - -L "$(EXT2_LABEL)" + -L "$(EXT2_LABEL)" \ + $(EXT2_MKFS_OPTS) ROOTFS_EXT2_DEPENDENCIES = host-e2fsprogs