Patchwork nets: fix a buffer overrun

login
register
mail settings
Submitter Jianjun kong
Date Nov. 8, 2008, 2:35 a.m.
Message ID <20081108023558.GB6384@ubuntu>
Download mbox | patch
Permalink /patch/7841/
State Accepted
Delegated to: David Miller
Headers show

Comments

Jianjun kong - Nov. 8, 2008, 2:35 a.m.
net/mac80211/debugfs_sta.c
The trailing zero was written to state[4], it's out of bounds.

Signed-off-by: Jianjun Kong <jianjun@zeuux.org>
---
 net/mac80211/debugfs_sta.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Nov. 11, 2008, 5:37 a.m.
From: Jianjun Kong <jianjun@zeuux.org>
Date: Sat, 8 Nov 2008 10:35:58 +0800

> net/mac80211/debugfs_sta.c
> The trailing zero was written to state[4], it's out of bounds.
> 
> Signed-off-by: Jianjun Kong <jianjun@zeuux.org>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c
index 189d0ba..b85c4f2 100644
--- a/net/mac80211/debugfs_sta.c
+++ b/net/mac80211/debugfs_sta.c
@@ -199,7 +199,7 @@  static ssize_t sta_agg_status_write(struct file *file,
 		/* toggle Rx aggregation command */
 		tid_num = tid_num - 100;
 		if (tid_static_rx[tid_num] == 1) {
-			strcpy(state, "off ");
+			strcpy(state, "off");
 			ieee80211_sta_stop_rx_ba_session(sta->sdata, da, tid_num, 0,
 					WLAN_REASON_QSTA_REQUIRE_SETUP);
 			sta->ampdu_mlme.tid_state_rx[tid_num] |=