Patchwork [U-Boot,V2,4/4] SMDK6400: Fix SMDK6400 SDRAM init

login
register
mail settings
Submitter seedshope
Date Jan. 11, 2011, 2:52 p.m.
Message ID <1294757545-4771-5-git-send-email-bocui107@gmail.com>
Download mbox | patch
Permalink /patch/78395/
State Rejected
Headers show

Comments

seedshope - Jan. 11, 2011, 2:52 p.m.
Since SDRAM init function have already change, So the SDRAM
initial function must be change.

Signed-off-by: seedshope <bocui107@gmail.com>
Sergei Shtylyov - Jan. 12, 2011, 11:08 a.m.
Hello.

On 11-01-2011 17:52, seedshope wrote:

> Since SDRAM init function have already change, So the SDRAM
> initial function must be change.

> Signed-off-by: seedshope<bocui107@gmail.com>

> diff --git a/board/samsung/smdk6400/smdk6400.c b/board/samsung/smdk6400/smdk6400.c
> index 35aa40b..52b44a8 100644
> --- a/board/samsung/smdk6400/smdk6400.c
> +++ b/board/samsung/smdk6400/smdk6400.c
> @@ -78,10 +78,18 @@ int board_init(void)
>   	return 0;
>   }
>
> -int dram_init(void)
> +void dram_init_banksize(void)
>   {
> +	DECLARE_GLOBAL_DATA_PTR;
> +
>   	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>   	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> +}
> +
> +int dram_init(void)
> +{
> +	gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
> +	CONFIG_MAX_RAM_BANK_SIZE);

    Please indent that line more to the right, preferrebly start it under 
'(volatile long *)'.

WBR, Sergei
seedshope - Jan. 12, 2011, 2:52 p.m.
On 01/12/2011 07:08 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 11-01-2011 17:52, seedshope wrote:
>
>> Since SDRAM init function have already change, So the SDRAM
>> initial function must be change.
>
>> Signed-off-by: seedshope<bocui107@gmail.com>
>
>> diff --git a/board/samsung/smdk6400/smdk6400.c 
>> b/board/samsung/smdk6400/smdk6400.c
>> index 35aa40b..52b44a8 100644
>> --- a/board/samsung/smdk6400/smdk6400.c
>> +++ b/board/samsung/smdk6400/smdk6400.c
>> @@ -78,10 +78,18 @@ int board_init(void)
>> return 0;
>> }
>>
>> -int dram_init(void)
>> +void dram_init_banksize(void)
>> {
>> + DECLARE_GLOBAL_DATA_PTR;
>> +
>> gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>> gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>> +}
>> +
>> +int dram_init(void)
>> +{
>> + gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
>> + CONFIG_MAX_RAM_BANK_SIZE);
>
> Please indent that line more to the right, preferrebly start it under 
> '(volatile long *)'.
ok, But I don't know how number tab indent is appropriate. May be the 
effect as following?
gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
CONFIG_MAX_RAM_BANK_SIZE);

Thanks,
seedshope

>
> WBR, Sergei
Wolfgang Denk - Jan. 12, 2011, 4:35 p.m.
Dear seedshope,

In message <4D2DC040.7040303@gmail.com> you wrote:
> 
> ok, But I don't know how number tab indent is appropriate. May be the
> effect as following?

You should start reading http://www.denx.de/wiki/U-Boot/CodingStyle
(and follow the links shown there).

Best regards,

Wolfgang Denk
Sergei Shtylyov - Jan. 13, 2011, 11:04 a.m.
Hello.

On 12-01-2011 17:52, seedshope wrote:

>>> Since SDRAM init function have already change, So the SDRAM
>>> initial function must be change.

>>> Signed-off-by: seedshope<bocui107@gmail.com>

>>> diff --git a/board/samsung/smdk6400/smdk6400.c
>>> b/board/samsung/smdk6400/smdk6400.c
>>> index 35aa40b..52b44a8 100644
>>> --- a/board/samsung/smdk6400/smdk6400.c
>>> +++ b/board/samsung/smdk6400/smdk6400.c
>>> @@ -78,10 +78,18 @@ int board_init(void)
>>> return 0;
>>> }
>>>
>>> -int dram_init(void)
>>> +void dram_init_banksize(void)
>>> {
>>> + DECLARE_GLOBAL_DATA_PTR;
>>> +
>>> gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
>>> gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
>>> +}
>>> +
>>> +int dram_init(void)
>>> +{
>>> + gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
>>> + CONFIG_MAX_RAM_BANK_SIZE);

>> Please indent that line more to the right, preferrebly start it under
>> '(volatile long *)'.

> ok, But I don't know how number tab indent is appropriate. May be the effect
> as following?
> gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
> CONFIG_MAX_RAM_BANK_SIZE);

    I've asked you specifically to do this:

	gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
				    CONFIG_MAX_RAM_BANK_SIZE);

> Thanks,
> seedshope

WBR, Sergei

Patch

diff --git a/board/samsung/smdk6400/smdk6400.c b/board/samsung/smdk6400/smdk6400.c
index 35aa40b..52b44a8 100644
--- a/board/samsung/smdk6400/smdk6400.c
+++ b/board/samsung/smdk6400/smdk6400.c
@@ -78,10 +78,18 @@  int board_init(void)
 	return 0;
 }
 
-int dram_init(void)
+void dram_init_banksize(void)
 {
+	DECLARE_GLOBAL_DATA_PTR;
+
 	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
 	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
+}
+
+int dram_init(void)
+{
+	gd->ram_size = get_ram_size((volatile long *)CONFIG_SYS_SDRAM_BASE,
+	CONFIG_MAX_RAM_BANK_SIZE);
 
 	return 0;
 }