diff mbox

Use secure_getenv for GOMP_DEBUG

Message ID 7e17de73-a785-9b63-cb5d-8cb68610ec4e@mentor.com
State New
Headers show

Commit Message

Tom de Vries July 3, 2017, 1:42 p.m. UTC 
On 07/03/2017 02:26 PM, Franz Sirl wrote:
> Am 27.06.17 um 13:10 schrieb Tom de Vries:
>> --- a/libgomp/plugin/plugin-hsa.c
>> +++ b/libgomp/plugin/plugin-hsa.c
>> @@ -39,32 +39,7 @@
>>   #include <dlfcn.h>
>>   #include "libgomp-plugin.h"
>>   #include "gomp-constants.h"
>> -
>> -/* Secure getenv() which returns NULL if running as SUID/SGID.  */
>> -#ifndef HAVE_SECURE_GETENV
>> -#ifdef HAVE___SECURE_GETENV
>> -#define secure_getenv __secure_getenv
>> -#elif defined (HAVE_UNISTD_H) && defined(HAVE_GETUID) && 
>> defined(HAVE_GETEUID) \
>> -  && defined(HAVE_GETGID) && defined(HAVE_GETEGID)
>> -
>> -#include <unistd.h>
>> -
>> -/* Implementation of secure_getenv() for targets where it is not 
>> provided but
>> -   we have at least means to test real and effective IDs. */
>> -
>> -static char *
>> -secure_getenv (const char *name)
>> -{
>> -  if ((getuid () == geteuid ()) && (getgid () == getegid ()))
>> -    return getenv (name);
>> -  else
>> -    return NULL;
>> -}
>> -
>> -#else
>> -#define secure_getenv getenv
>> -#endif
>> -#endif
>> +#include "secure-getenv.h"
> 
> Hi,
> 
> that should be secure_getenv.h (underscore instead of dash).

Hi Franz,

sorry for the breakage.

Fixed in attached patch.

Committed.

Thanks,
- Tom
diff mbox

Patch

Fix secure_getenv.h include in plugin-hsa.c

2017-07-03  Tom de Vries  <tom@codesourcery.com>

	* plugin/plugin-hsa.c: Fix secure_getenv.h include.

---
 libgomp/plugin/plugin-hsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libgomp/plugin/plugin-hsa.c b/libgomp/plugin/plugin-hsa.c
index adb07ac..fc08f5d 100644
--- a/libgomp/plugin/plugin-hsa.c
+++ b/libgomp/plugin/plugin-hsa.c
@@ -39,7 +39,7 @@ 
 #include <dlfcn.h>
 #include "libgomp-plugin.h"
 #include "gomp-constants.h"
-#include "secure-getenv.h"
+#include "secure_getenv.h"
 
 /* As an HSA runtime is dlopened, following structure defines function
    pointers utilized by the HSA plug-in.  */