diff mbox

[rs6000] PR80103: Fix typo in test case

Message ID b8ac11b2-771d-3b59-22b0-4f10ab4bbf4a@linux.vnet.ibm.com
State New
Headers show

Commit Message

Kelvin Nilsen June 30, 2017, 3:56 p.m. UTC 
While reviewing regression test results for a back port of the PR80103
patch, I discovered a typographic error in the test case.  This patch
corrects the error.

I have tested this fix on powerpc64le-unknown-linux-gnu with no
regressions.  Is this ok for trunk?

gcc/testsuite/ChangeLog:

2017-06-30  Kelvin Nilsen  <kelvin@gcc.gnu.org>

	PR target/80103
	* gcc.target/powerpc/pr80103-1.c (b): Correct spelling of
	__attribute__.

Comments

Peter Bergner June 30, 2017, 4:08 p.m. UTC | #1 
On 6/30/17 10:56 AM, Kelvin Nilsen wrote:
> While reviewing regression test results for a back port of the PR80103
> patch, I discovered a typographic error in the test case.  This patch
> corrects the error.
> 
> I have tested this fix on powerpc64le-unknown-linux-gnu with no
> regressions.  Is this ok for trunk?

This falls under the "obvious" rule.  Go ahead.

Peter
Segher Boessenkool June 30, 2017, 11:35 p.m. UTC | #2 
On Fri, Jun 30, 2017 at 09:56:03AM -0600, Kelvin Nilsen wrote:
> 
> While reviewing regression test results for a back port of the PR80103
> patch, I discovered a typographic error in the test case.  This patch
> corrects the error.

A syntax error, even...  I wonder why we haven't noticed that before.
It won't compile as-is afaics?

> --- gcc/testsuite/gcc.target/powerpc/pr80103-1.c	(revision 249798)
> +++ gcc/testsuite/gcc.target/powerpc/pr80103-1.c	(working copy)
> @@ -12,5 +12,5 @@
>  int a;
>  void b (__attribute__ ((__vector_size__ (16))) char c)
>  {
> -  a = ((__attributes__ ((__vector_size__ (2 * sizeof (long)))) long) c)[0];
> +  a = ((__attribute__ ((__vector_size__ (2 * sizeof (long)))) long) c)[0];
>  }


Segher
diff mbox

Patch

Index: gcc/testsuite/gcc.target/powerpc/pr80103-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/pr80103-1.c	(revision 249798)
+++ gcc/testsuite/gcc.target/powerpc/pr80103-1.c	(working copy)
@@ -12,5 +12,5 @@ 
 int a;
 void b (__attribute__ ((__vector_size__ (16))) char c)
 {
-  a = ((__attributes__ ((__vector_size__ (2 * sizeof (long)))) long) c)[0];
+  a = ((__attribute__ ((__vector_size__ (2 * sizeof (long)))) long) c)[0];
 }