| Message ID | alpine.LNX.2.00.1101110044580.32164@swampdragon.chaosbits.net |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi, > We need to release_firmware() in order not to leak memory. > > Signed-off-by: Jesper Juhl <jj@chaosbits.net> I can assume that release_firmware() checks if 'fw' is null? If so: Acked-by: Ivo van Doorn <IvDoorn@gmail.com> > --- > rt2x00firmware.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/rt2x00/rt2x00firmware.c b/drivers/net/wireless/rt2x00/rt2x00firmware.c > index f0e1eb7..be0ff78 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00firmware.c > +++ b/drivers/net/wireless/rt2x00/rt2x00firmware.c > @@ -58,6 +58,7 @@ static int rt2x00lib_request_firmware(struct rt2x00_dev *rt2x00dev) > > if (!fw || !fw->size || !fw->data) { > ERROR(rt2x00dev, "Failed to read Firmware.\n"); > + release_firmware(fw); > return -ENOENT; > } > > > > -- > Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ > Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html > Plain text mails only, please. > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 11, 2011 at 7:30 PM, Ivo Van Doorn <ivdoorn@gmail.com> wrote: > Hi, > >> We need to release_firmware() in order not to leak memory. >> >> Signed-off-by: Jesper Juhl <jj@chaosbits.net> > > I can assume that release_firmware() checks if 'fw' is null? Yes, it does. > If so: > > Acked-by: Ivo van Doorn <IvDoorn@gmail.com> Acked-by: Pekka Enberg <penberg@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/rt2x00/rt2x00firmware.c b/drivers/net/wireless/rt2x00/rt2x00firmware.c index f0e1eb7..be0ff78 100644 --- a/drivers/net/wireless/rt2x00/rt2x00firmware.c +++ b/drivers/net/wireless/rt2x00/rt2x00firmware.c @@ -58,6 +58,7 @@ static int rt2x00lib_request_firmware(struct rt2x00_dev *rt2x00dev) if (!fw || !fw->size || !fw->data) { ERROR(rt2x00dev, "Failed to read Firmware.\n"); + release_firmware(fw); return -ENOENT; }
We need to release_firmware() in order not to leak memory. Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- rt2x00firmware.c | 1 + 1 file changed, 1 insertion(+)