| Message ID | 453bac0f21aa525d7c9de38d4c8c509b44c4ecda.1498761179.git.alistair.francis@xilinx.com |
|---|---|
| State | New |
| Headers | show |
On 06/29/2017 02:42 PM, Alistair Francis wrote: > When QEMU is waiting for a TCP socket connection it reports that message as > an error. This isn't an error it is just informaiton so let's change the > report to use report() instead. > > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> > --- > > chardev/char-socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > index ccc499cfa1..ad1b3d6e93 100644 > --- a/chardev/char-socket.c > +++ b/chardev/char-socket.c > @@ -765,7 +765,7 @@ static int tcp_chr_wait_connected(Chardev *chr, Error **errp) > * in TLS and telnet cases, only wait for an accepted socket */ > while (!s->ioc) { > if (s->is_listen) { > - error_report("QEMU waiting for connection on: %s", > + report(INFO, "QEMU waiting for connection on: %s", > chr->filename); Indentation looks off now; I'd scoot chr->filename to live right under INFO.
On Thu, Jun 29, 2017 at 1:48 PM, Eric Blake <eblake@redhat.com> wrote: > On 06/29/2017 02:42 PM, Alistair Francis wrote: >> When QEMU is waiting for a TCP socket connection it reports that message as >> an error. This isn't an error it is just informaiton so let's change the >> report to use report() instead. >> >> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> >> --- >> >> chardev/char-socket.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/chardev/char-socket.c b/chardev/char-socket.c >> index ccc499cfa1..ad1b3d6e93 100644 >> --- a/chardev/char-socket.c >> +++ b/chardev/char-socket.c >> @@ -765,7 +765,7 @@ static int tcp_chr_wait_connected(Chardev *chr, Error **errp) >> * in TLS and telnet cases, only wait for an accepted socket */ >> while (!s->ioc) { >> if (s->is_listen) { >> - error_report("QEMU waiting for connection on: %s", >> + report(INFO, "QEMU waiting for connection on: %s", >> chr->filename); > > Indentation looks off now; I'd scoot chr->filename to live right under INFO. Woops I missed that. Thanks, I made your fixes to both patches. Thanks, Alistair > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org >
diff --git a/chardev/char-socket.c b/chardev/char-socket.c index ccc499cfa1..ad1b3d6e93 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -765,7 +765,7 @@ static int tcp_chr_wait_connected(Chardev *chr, Error **errp) * in TLS and telnet cases, only wait for an accepted socket */ while (!s->ioc) { if (s->is_listen) { - error_report("QEMU waiting for connection on: %s", + report(INFO, "QEMU waiting for connection on: %s", chr->filename); qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), true, NULL); tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr);
When QEMU is waiting for a TCP socket connection it reports that message as an error. This isn't an error it is just informaiton so let's change the report to use report() instead. Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> --- chardev/char-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)