[v8,14/18] block: convert to errseq_t based writeback error tracking

Submitted by jlayton@kernel.org on June 29, 2017, 1:19 p.m.

Details

Message ID 20170629131954.28733-15-jlayton@kernel.org
State New
Headers show

Commit Message

jlayton@kernel.org June 29, 2017, 1:19 p.m.
From: Jeff Layton <jlayton@redhat.com>

This is a very minimal conversion to errseq_t based error tracking
for raw block device access. Just have it use the standard
file_write_and_wait_range call.

Note that there are internal callers that call sync_blockdev
and the like that are not affected by this. They'll continue
to use the AS_EIO/AS_ENOSPC flags for error reporting like
they always have for now.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
 fs/block_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig June 29, 2017, 2:18 p.m.
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Patch hide | download patch | download mbox

diff --git a/fs/block_dev.c b/fs/block_dev.c
index 4d62fe771587..bcb0be6e423a 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -624,7 +624,7 @@  int blkdev_fsync(struct file *filp, loff_t start, loff_t end, int datasync)
 	struct block_device *bdev = I_BDEV(bd_inode);
 	int error;
 	
-	error = filemap_write_and_wait_range(filp->f_mapping, start, end);
+	error = file_write_and_wait_range(filp, start, end);
 	if (error)
 		return error;