Patchwork [03/28] mn10300: delete ASM_PN_FORMAT

login
register
mail settings
Submitter Richard Henderson
Date Jan. 10, 2011, 8:31 p.m.
Message ID <1294691517-19580-4-git-send-email-rth@redhat.com>
Download mbox | patch
Permalink /patch/78201/
State New
Headers show

Comments

Richard Henderson - Jan. 10, 2011, 8:31 p.m.
From: Richard Henderson <rth@twiddle.net>

Is there any real reason for this?  It causes testsuite failures
because the pattern doesn't match many of the dumps.
---
 gcc/config/mn10300/mn10300.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Jeff Law - Jan. 11, 2011, 2:45 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/10/11 13:31, Richard Henderson wrote:
> From: Richard Henderson <rth@twiddle.net>
> 
> Is there any real reason for this?  It causes testsuite failures
> because the pattern doesn't match many of the dumps.
> ---
>  gcc/config/mn10300/mn10300.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/gcc/config/mn10300/mn10300.h b/gcc/config/mn10300/mn10300.h
> index edc17f5..468c031 100644
> --- a/gcc/config/mn10300/mn10300.h
> +++ b/gcc/config/mn10300/mn10300.h
> @@ -656,7 +656,10 @@ struct cum_arg
>  #define ASM_OUTPUT_LABELREF(FILE, NAME) \
>    asm_fprintf (FILE, "%U%s", (*targetm.strip_name_encoding) (NAME))
>  
> +/* ??? Is there any real reason for this?  It mucks up pattern matching
> +   in the tree-ssa.exp testsuite.
>  #define ASM_PN_FORMAT "%s___%lu"
> +*/
>  
>  /* This is how we tell the assembler that two symbols have the same value.  */
>  
I can't think of a reason.  It's something Kaveh added almost 10 years
ago...

Jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNLGz2AAoJEBRtltQi2kC7cf0H/0WX2zkuHYEEnSITUHJipVwB
0GdGY95IoHArtDbZCMri9YPPMNvjuaQRppTusxNjBpKrg+krCxZYcZKuaUrwYj4w
RogfiL16TP0NW8Q1Ur602ryboNJY9jWxFx+P38PkL2YAu5TpH5Fv0CY40D6egSSz
qlpjG8fcV/k+qLwZU1reVRRLzBVdN/A47hlWogeYyC1uFJK0q9A8+yFm/huOt7Sh
2J2lBCGJ95OTwaIFjbuHCec7nootM4U7qW5nE6PYSb4Vb6ea/fsFiRs+t8S6yiPa
xIEbJ4qKjpdjkM6Ywnn2qC8QZzkgDIelFwKRzoY/lqvanNYOv5QEMrK3y3UgWss=
=Qa/n
-----END PGP SIGNATURE-----

Patch

diff --git a/gcc/config/mn10300/mn10300.h b/gcc/config/mn10300/mn10300.h
index edc17f5..468c031 100644
--- a/gcc/config/mn10300/mn10300.h
+++ b/gcc/config/mn10300/mn10300.h
@@ -656,7 +656,10 @@  struct cum_arg
 #define ASM_OUTPUT_LABELREF(FILE, NAME) \
   asm_fprintf (FILE, "%U%s", (*targetm.strip_name_encoding) (NAME))
 
+/* ??? Is there any real reason for this?  It mucks up pattern matching
+   in the tree-ssa.exp testsuite.
 #define ASM_PN_FORMAT "%s___%lu"
+*/
 
 /* This is how we tell the assembler that two symbols have the same value.  */