| Message ID | 1498672672.7044.11.camel@us.ibm.com |
|---|---|
| State | New |
| Headers | show |
Hi Carl, On Wed, Jun 28, 2017 at 10:57:52AM -0700, Carl Love wrote: > The vec_reve builtin test builtins-3-vec_reve-runnable did not have a > minimum Power processor specified. The thought was the instructions for > the builtin were available on all the older processors. Unfortunately, > it turns out the builtin does require vsx hardware (-mvsx option). Bill > Schmidt said that the minimum platform that the builtins need to be > supported on is Power 7. The following patch sets the minimum platform > as Power 7. > > Please let me know if the following patch is acceptable. Thanks. Sure, that works. Or just skip the testcase then (but we don't yet have a convenient way to do that). Okay for trunk (nit below). > 2017-06-28 Carl Love <cel@us.ibm.com> > > * gcc.target/powerpc/builtins-3-vec_reve-runnable.c (dg-options, > dg-skip-if): add mcpu=power7 Start with a capital, end with a dot. The dg-skip-if is new... Maybe just lazily write * gcc.target/powerpc/builtins-3-vec_reve-runnable.c: Use -mvsx -mcpu=power7. :-) Thanks, Segher
diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-3-vec_reve-runnable.c b/gcc/testsuite/gcc.target/powerpc/builtins-3-vec_reve-runnable.c index 9c05de0..f7c3c3d 100644 --- a/gcc/testsuite/gcc.target/powerpc/builtins-3-vec_reve-runnable.c +++ b/gcc/testsuite/gcc.target/powerpc/builtins-3-vec_reve-runnable.c @@ -1,6 +1,6 @@ /* { dg-do run { target { powerpc*-*-linux* } } } */ -/* { dg-options "-O2" } */ - +/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power7" } } */ +/* { dg-options "-O2 -mvsx -mcpu=power7" } */ #include <altivec.h> // vector
GCC Maintainers: The vec_reve builtin test builtins-3-vec_reve-runnable did not have a minimum Power processor specified. The thought was the instructions for the builtin were available on all the older processors. Unfortunately, it turns out the builtin does require vsx hardware (-mvsx option). Bill Schmidt said that the minimum platform that the builtins need to be supported on is Power 7. The following patch sets the minimum platform as Power 7. Please let me know if the following patch is acceptable. Thanks. Carl Love -------------------------------------------------- From 5b9a8b9d654f243345189247818196f47573333e Mon Sep 17 00:00:00 2001 From: Carl Love <carll@us.ibm.com> Date: Wed, 28 Jun 2017 12:56:18 -0500 Subject: [PATCH] builtins-3-vec_reve-runnable fix minimum platform gcc/ChangeLog: 2017-06-28 Carl Love <cel@us.ibm.com> * gcc.target/powerpc/builtins-3-vec_reve-runnable.c (dg-options, dg-skip-if): add mcpu=power7 --- gcc/testsuite/gcc.target/powerpc/builtins-3-vec_reve-runnable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)