Patchwork qemu-img snapshot: Use writeback caching

login
register
mail settings
Submitter Kevin Wolf
Date Jan. 10, 2011, 4:54 p.m.
Message ID <1294678460-7492-1-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/78172/
State New
Headers show

Comments

Kevin Wolf - Jan. 10, 2011, 4:54 p.m.
None of the other qemu-img subcommands uses writethrough, and there's no reason
why snapshot should be special.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qemu-img.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Stefan Hajnoczi - Jan. 10, 2011, 9:53 p.m.
On Mon, Jan 10, 2011 at 4:54 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> None of the other qemu-img subcommands uses writethrough, and there's no reason
> why snapshot should be special.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qemu-img.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

Patch

diff --git a/qemu-img.c b/qemu-img.c
index afd9ed2..1e65ea8 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1068,7 +1068,7 @@  static int img_snapshot(int argc, char **argv)
     int action = 0;
     qemu_timeval tv;
 
-    bdrv_oflags = BDRV_O_RDWR;
+    bdrv_oflags = BDRV_O_FLAGS | BDRV_O_RDWR;
     /* Parse commandline parameters */
     for(;;) {
         c = getopt(argc, argv, "la:c:d:h");