Patchwork USB: Fix USB Kconfig dependency problem on 85xx/QoirQ platforms

login
register
mail settings
Submitter Xulei
Date Jan. 10, 2011, 10:06 a.m.
Message ID <1294654017-32568-1-git-send-email-B33228@freescale.com>
Download mbox | patch
Permalink /patch/78110/
State Not Applicable
Headers show

Comments

Xulei - Jan. 10, 2011, 10:06 a.m.
For FSL PPC SoCs USB_ARCH_HAS_EHCI currently on depends on PPC_83xx.
However that excludes support for USB on 85xx & QorIQ devices.  Use
FSL_SOC insted which will get us 83xx, 85xx, QorIQ, and 5xxx which all
have the same USB IP on them.

Signed-off-by: Xulei <B33228@freescale.com>
Signed-off-by: Kumar Gala <kumar.gala@freescale.com>
---
 drivers/usb/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Kumar Gala - Jan. 10, 2011, 4:22 p.m.
On Jan 10, 2011, at 4:06 AM, Xulei wrote:

> For FSL PPC SoCs USB_ARCH_HAS_EHCI currently on depends on PPC_83xx.
> However that excludes support for USB on 85xx & QorIQ devices.  Use
> FSL_SOC insted which will get us 83xx, 85xx, QorIQ, and 5xxx which all
> have the same USB IP on them.
> 
> Signed-off-by: Xulei <B33228@freescale.com>
> Signed-off-by: Kumar Gala <kumar.gala@freescale.com>
> ---
> drivers/usb/Kconfig |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 6a58cb1..d513d3a 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -57,7 +57,7 @@ config USB_ARCH_HAS_OHCI
> # some non-PCI hcds implement EHCI
> config USB_ARCH_HAS_EHCI
> 	boolean
> -	default y if PPC_83xx
> +	default y if FSL_SOC
> 	default y if SOC_AU1200
> 	default y if ARCH_IXP4XX
> 	default y if ARCH_W90X900
> -- 
> 1.7.0.4

This really should have been CC'd to the USB list & maintainer.

- k
Xulei - Jan. 11, 2011, 11:51 a.m.
Thanks very much.
I'm sorry for that and will get it later.

On δΈ€, 2011-01-10 at 10:22 -0600, Kumar Gala wrote:
> On Jan 10, 2011, at 4:06 AM, Xulei wrote:
> 
> > For FSL PPC SoCs USB_ARCH_HAS_EHCI currently on depends on PPC_83xx.
> > However that excludes support for USB on 85xx & QorIQ devices.  Use
> > FSL_SOC insted which will get us 83xx, 85xx, QorIQ, and 5xxx which all
> > have the same USB IP on them.
> > 
> > Signed-off-by: Xulei <B33228@freescale.com>
> > Signed-off-by: Kumar Gala <kumar.gala@freescale.com>
> > ---
> > drivers/usb/Kconfig |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> > index 6a58cb1..d513d3a 100644
> > --- a/drivers/usb/Kconfig
> > +++ b/drivers/usb/Kconfig
> > @@ -57,7 +57,7 @@ config USB_ARCH_HAS_OHCI
> > # some non-PCI hcds implement EHCI
> > config USB_ARCH_HAS_EHCI
> > 	boolean
> > -	default y if PPC_83xx
> > +	default y if FSL_SOC
> > 	default y if SOC_AU1200
> > 	default y if ARCH_IXP4XX
> > 	default y if ARCH_W90X900
> > -- 
> > 1.7.0.4
> 
> This really should have been CC'd to the USB list & maintainer.
> 
> - k

Patch

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 6a58cb1..d513d3a 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -57,7 +57,7 @@  config USB_ARCH_HAS_OHCI
 # some non-PCI hcds implement EHCI
 config USB_ARCH_HAS_EHCI
 	boolean
-	default y if PPC_83xx
+	default y if FSL_SOC
 	default y if SOC_AU1200
 	default y if ARCH_IXP4XX
 	default y if ARCH_W90X900