From patchwork Mon Jan 10 08:32:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 78094 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E0039B6EE9 for ; Mon, 10 Jan 2011 19:46:02 +1100 (EST) Received: from localhost ([127.0.0.1]:54840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcDO3-0001Fo-Tn for incoming@patchwork.ozlabs.org; Mon, 10 Jan 2011 03:45:59 -0500 Received: from [140.186.70.92] (port=52381 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PcDB2-0003iJ-U4 for qemu-devel@nongnu.org; Mon, 10 Jan 2011 03:32:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PcDAx-0006PJ-MN for qemu-devel@nongnu.org; Mon, 10 Jan 2011 03:32:32 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:50089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PcDAx-0006P2-G8 for qemu-devel@nongnu.org; Mon, 10 Jan 2011 03:32:27 -0500 Received: from smtp06.web.de ( [172.20.5.172]) by fmmailgate02.web.de (Postfix) with ESMTP id E0BC0193229E7; Mon, 10 Jan 2011 09:32:26 +0100 (CET) Received: from [92.75.141.173] (helo=localhost.localdomain) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #2) id 1PcDAw-0006T2-00; Mon, 10 Jan 2011 09:32:26 +0100 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Date: Mon, 10 Jan 2011 09:32:08 +0100 Message-Id: <9e232d73dd169900e78a517693db8c1ab0a0abee.1294648329.git.jan.kiszka@web.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1+a2G0o4eOml8iw//8MPgnjauHta9QARRUuPJBX Ab3rjXRUxn9rS/+sI8apaQI26irpWgxNFVel19podlUpOgq6jS tde0Ip7GI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: [Qemu-devel] [PATCH 15/18] kvm: Leave kvm_cpu_exec directly after KVM_EXIT_SHUTDOWN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Jan Kiszka The reset we issue on KVM_EXIT_SHUTDOWN implies that we should also leave the VCPU loop. As we now check for exit_request which is set by qemu_system_reset_request, this bug is no longer critical. Still it's an unneeded extra turn. Signed-off-by: Jan Kiszka --- kvm-all.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index fb4d73e..0abe088 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -891,7 +891,6 @@ int kvm_cpu_exec(CPUState *env) case KVM_EXIT_SHUTDOWN: DPRINTF("shutdown\n"); qemu_system_reset_request(); - ret = 1; break; case KVM_EXIT_UNKNOWN: fprintf(stderr, "KVM: unknown exit, hardware reason %" PRIx64 "\n",