| Message ID | 1498489947-17272-1-git-send-email-madalin.bucur@nxp.com |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur@nxp.com> wrote: > A previous commit inserted a dependency on DMA API that requires > HAS_DMA to be added in Kconfig. It would be nice to specify the commit that caused this.
> -----Original Message----- > From: Fabio Estevam [mailto:festevam@gmail.com] > Sent: Monday, June 26, 2017 6:21 PM > To: Madalin-cristian Bucur <madalin.bucur@nxp.com> > Cc: netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; Geert > Uytterhoeven <geert@linux-m68k.org>; linuxppc-dev@lists.ozlabs.org; linux- > kernel <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA > > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur@nxp.com> > wrote: > > A previous commit inserted a dependency on DMA API that requires > > HAS_DMA to be added in Kconfig. > > It would be nice to specify the commit that caused this. Sent v2, thanks. Madalin
On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam <festevam@gmail.com> wrote: > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur@nxp.com> wrote: >> A previous commit inserted a dependency on DMA API that requires >> HAS_DMA to be added in Kconfig. > > It would be nice to specify the commit that caused this. That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops"). However, none of the fman code uses any DMA API calls, so IMHO the set_dma_ops() should be done somewhere else. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> -----Original Message----- > From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com] > On Behalf Of Geert Uytterhoeven > Sent: Monday, June 26, 2017 7:17 PM > To: Fabio Estevam <festevam@gmail.com> > Cc: Madalin-cristian Bucur <madalin.bucur@nxp.com>; > netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; linuxppc- > dev@lists.ozlabs.org; linux-kernel <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA > > On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam <festevam@gmail.com> wrote: > > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur@nxp.com> > wrote: > >> A previous commit inserted a dependency on DMA API that requires > >> HAS_DMA to be added in Kconfig. > > > > It would be nice to specify the commit that caused this. > > That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops"). > > However, none of the fman code uses any DMA API calls, so IMHO > the set_dma_ops() should be done somewhere else. The Ethernet driver is making use of the DMA ops set here. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds
diff --git a/drivers/net/ethernet/freescale/fman/Kconfig b/drivers/net/ethernet/freescale/fman/Kconfig index dc0850b..8870a9a 100644 --- a/drivers/net/ethernet/freescale/fman/Kconfig +++ b/drivers/net/ethernet/freescale/fman/Kconfig @@ -2,6 +2,7 @@ config FSL_FMAN tristate "FMan support" depends on FSL_SOC || ARCH_LAYERSCAPE || COMPILE_TEST select GENERIC_ALLOCATOR + depends on HAS_DMA select PHYLIB default n help
A previous commit inserted a dependency on DMA API that requires HAS_DMA to be added in Kconfig. Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/ethernet/freescale/fman/Kconfig | 1 + 1 file changed, 1 insertion(+)