| Message ID | 1498488802-1439-1-git-send-email-jacob-chen@iotwrt.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Mon, Jun 26, 2017 at 10:53:22PM +0800, Jacob Chen wrote: > Add DT bindings documentation for Rockchip RGA > > Signed-off-by: Yakir Yang <ykk@rock-chips.com> > Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com> > --- > .../devicetree/bindings/media/rockchip-rga.txt | 36 ++++++++++++++++++++++ Should be under bindings/gpu/ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip-rga.txt > > diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.txt b/Documentation/devicetree/bindings/media/rockchip-rga.txt > new file mode 100644 > index 0000000..48a260e5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip-rga.txt > @@ -0,0 +1,36 @@ > +device-tree bindings for rockchip 2D raster graphic acceleration controller (RGA) > + > +RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D > +graphics operations, such as point/line drawing, image scaling, rotation, > +BitBLT, alpha blending and image blur/sharpness. > + > +Required properties: > +- compatible: value should be one of the following > + "rockchip,rk3228-rga"; > + "rockchip,rk3288-rga"; > + "rockchip,rk3399-rga"; > + > +- interrupts: RGA interrupt number. > + > +- clocks: phandle to RGA sclk/hclk/aclk clocks > + > +- clock-names: should be "aclk" "hclk" and "sclk" > + > +- resets: Must contain an entry for each entry in reset-names. > + See ../reset/reset.txt for details. > +- reset-names: should be "core" "axi" and "ahb" > + > +Example: > +SoC specific DT entry: > + rga: rga@ff680000 { gpu@... > + compatible = "rockchip,rk3399-rga"; > + reg = <0xff680000 0x10000>; > + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "rga"; > + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE>; > + clock-names = "aclk", "hclk", "sclk"; > + > + resets = <&cru SRST_RGA_CORE>, <&cru SRST_A_RGA>, <&cru SRST_H_RGA>; > + reset-names = "core, "axi", "ahb"; > + status = "disabled"; Don't show status in examples. > + }; > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi rob, 2017-06-29 6:29 GMT+08:00 Rob Herring <robh@kernel.org>: > On Mon, Jun 26, 2017 at 10:53:22PM +0800, Jacob Chen wrote: >> Add DT bindings documentation for Rockchip RGA >> >> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com> >> --- >> .../devicetree/bindings/media/rockchip-rga.txt | 36 ++++++++++++++++++++++ > > Should be under bindings/gpu/ > >> 1 file changed, 36 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/rockchip-rga.txt >> >> diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.txt b/Documentation/devicetree/bindings/media/rockchip-rga.txt >> new file mode 100644 >> index 0000000..48a260e5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/rockchip-rga.txt >> @@ -0,0 +1,36 @@ >> +device-tree bindings for rockchip 2D raster graphic acceleration controller (RGA) >> + >> +RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D >> +graphics operations, such as point/line drawing, image scaling, rotation, >> +BitBLT, alpha blending and image blur/sharpness. >> + >> +Required properties: >> +- compatible: value should be one of the following >> + "rockchip,rk3228-rga"; >> + "rockchip,rk3288-rga"; >> + "rockchip,rk3399-rga"; >> + >> +- interrupts: RGA interrupt number. >> + >> +- clocks: phandle to RGA sclk/hclk/aclk clocks >> + >> +- clock-names: should be "aclk" "hclk" and "sclk" >> + >> +- resets: Must contain an entry for each entry in reset-names. >> + See ../reset/reset.txt for details. >> +- reset-names: should be "core" "axi" and "ahb" >> + >> +Example: >> +SoC specific DT entry: >> + rga: rga@ff680000 { > > gpu@... > It's used for v4l2 drvier, should i move it bindings/gpu/? >> + compatible = "rockchip,rk3399-rga"; >> + reg = <0xff680000 0x10000>; >> + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-names = "rga"; >> + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE>; >> + clock-names = "aclk", "hclk", "sclk"; >> + >> + resets = <&cru SRST_RGA_CORE>, <&cru SRST_A_RGA>, <&cru SRST_H_RGA>; >> + reset-names = "core, "axi", "ahb"; >> + status = "disabled"; > > Don't show status in examples. > >> + }; >> -- >> 2.7.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.txt b/Documentation/devicetree/bindings/media/rockchip-rga.txt new file mode 100644 index 0000000..48a260e5 --- /dev/null +++ b/Documentation/devicetree/bindings/media/rockchip-rga.txt @@ -0,0 +1,36 @@ +device-tree bindings for rockchip 2D raster graphic acceleration controller (RGA) + +RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D +graphics operations, such as point/line drawing, image scaling, rotation, +BitBLT, alpha blending and image blur/sharpness. + +Required properties: +- compatible: value should be one of the following + "rockchip,rk3228-rga"; + "rockchip,rk3288-rga"; + "rockchip,rk3399-rga"; + +- interrupts: RGA interrupt number. + +- clocks: phandle to RGA sclk/hclk/aclk clocks + +- clock-names: should be "aclk" "hclk" and "sclk" + +- resets: Must contain an entry for each entry in reset-names. + See ../reset/reset.txt for details. +- reset-names: should be "core" "axi" and "ahb" + +Example: +SoC specific DT entry: + rga: rga@ff680000 { + compatible = "rockchip,rk3399-rga"; + reg = <0xff680000 0x10000>; + interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "rga"; + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA_CORE>; + clock-names = "aclk", "hclk", "sclk"; + + resets = <&cru SRST_RGA_CORE>, <&cru SRST_A_RGA>, <&cru SRST_H_RGA>; + reset-names = "core, "axi", "ahb"; + status = "disabled"; + };