| Message ID | 20170626140601.7106-1-msuchanek@suse.de (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Mon, 26 Jun 2017 16:06:00 +0200 Michal Suchanek <msuchanek@suse.de> wrote: > When fadump is already registered return success. > > Currently EEXIST is returned which is difficult to handle race-free in > userspace when shell scripts are used. If multiple writers are trying > to write '1' there is no difference in whichever succeeds so just > return 0 to all. > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> > --- > arch/powerpc/kernel/fadump.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kernel/fadump.c > b/arch/powerpc/kernel/fadump.c index 436aedf195ab..5a7355381dac 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -1214,7 +1214,6 @@ static ssize_t fadump_register_store(struct > kobject *kobj, break; > case '1': > if (fw_dump.dump_registered == 1) { > - ret = -EEXIST; > goto unlock_out; > } > /* Register Firmware-assisted dump */ Forget about this one. It breaks another case when fadump is registered and you need to re-register to account for change in system configuration. Thanks Michal
diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c index 436aedf195ab..5a7355381dac 100644 --- a/arch/powerpc/kernel/fadump.c +++ b/arch/powerpc/kernel/fadump.c @@ -1214,7 +1214,6 @@ static ssize_t fadump_register_store(struct kobject *kobj, break; case '1': if (fw_dump.dump_registered == 1) { - ret = -EEXIST; goto unlock_out; } /* Register Firmware-assisted dump */
When fadump is already registered return success. Currently EEXIST is returned which is difficult to handle race-free in userspace when shell scripts are used. If multiple writers are trying to write '1' there is no difference in whichever succeeds so just return 0 to all. Signed-off-by: Michal Suchanek <msuchanek@suse.de> --- arch/powerpc/kernel/fadump.c | 1 - 1 file changed, 1 deletion(-)