Patchwork [U-Boot,V2,4/5] mvmfp: add MFP configuration support for PANTHEON

login
register
mail settings
Submitter Lei Wen
Date Jan. 10, 2011, 4:01 a.m.
Message ID <1294632087-8025-5-git-send-email-leiwen@marvell.com>
Download mbox | patch
Permalink /patch/78068/
State Superseded
Headers show

Comments

Lei Wen - Jan. 10, 2011, 4:01 a.m.
This patch adds the support MFP support for Marvell PANTHEON SoCs

Signed-off-by: Lei Wen <leiwen@marvell.com>
---
 arch/arm/include/asm/arch-pantheon/mfp.h |   42 ++++++++++++++++++++++++++++++
 drivers/gpio/mvmfp.c                     |    2 +
 2 files changed, 44 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-pantheon/mfp.h
Wolfgang Denk - Jan. 25, 2011, 9:34 p.m.
Dear Lei Wen,

In message <1294632087-8025-5-git-send-email-leiwen@marvell.com> you wrote:
> This patch adds the support MFP support for Marvell PANTHEON SoCs

"the support MFP support" ??

Please fix. Also, please explain what MFP is. It may be obvious to
you, it ain't so for me.

> +/*
> + * Frequently used MFP Configuration macros for all PANTHEON family of
> +SoCs

Line wrapped - please fix.


Best regards,

Wolfgang Denk
Lei Wen - Jan. 26, 2011, 1:51 a.m.
Hi Wolfgang,

On Wed, Jan 26, 2011 at 5:34 AM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Lei Wen,
>
> In message <1294632087-8025-5-git-send-email-leiwen@marvell.com> you wrote:
>> This patch adds the support MFP support for Marvell PANTHEON SoCs
>
> "the support MFP support" ??
>
> Please fix. Also, please explain what MFP is. It may be obvious to
> you, it ain't so for me.
>
>> +/*
>> + * Frequently used MFP Configuration macros for all PANTHEON family of
>> +SoCs
>
> Line wrapped - please fix.
>
>
This already fixed in the v6 patch, maybe you didn't notice this...
http://patchwork.ozlabs.org/patch/80307/

Best regards,
Lei
Wolfgang Denk - Jan. 26, 2011, 7:39 a.m.
Dear Lei Wen,

In message <AANLkTikKdESNw=7bnpcR8Yr8TZtD=Q=MmGGNd9ELJBBj@mail.gmail.com> you wrote:
> 
> >> This patch adds the support MFP support for Marvell PANTHEON SoCs
> >
> > "the support MFP support" ??
> >
> > Please fix. Also, please explain what MFP is. It may be obvious to
> > you, it ain't so for me.
> >
> >> +/*
> >> + * Frequently used MFP Configuration macros for all PANTHEON family of
> >> +SoCs
> >
> > Line wrapped - please fix.
> >
> >
> This already fixed in the v6 patch, maybe you didn't notice this...
> http://patchwork.ozlabs.org/patch/80307/

Only the line wrap was fixed.  

The other 2 remarks still apply.


Best regards,

Wolfgang Denk
Wolfgang Denk - Jan. 26, 2011, 7:44 a.m.
Dear Lei Wen,

In message <AANLkTikKdESNw=7bnpcR8Yr8TZtD=Q=MmGGNd9ELJBBj@mail.gmail.com> you wrote:
> 
> This already fixed in the v6 patch, maybe you didn't notice this...

Yes, I missed this v6 series of patches, because it seems you broke
the mail thread when sending it.

Please see
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
bullet # 3.

Best regards,

Wolfgang Denk
Lei Wen - Jan. 26, 2011, 7:48 a.m.
Hi Wolfgang,

On Wed, Jan 26, 2011 at 3:39 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Lei Wen,
>
> In message <AANLkTikKdESNw=7bnpcR8Yr8TZtD=Q=MmGGNd9ELJBBj@mail.gmail.com> you wrote:
>>
>> >> This patch adds the support MFP support for Marvell PANTHEON SoCs
>> >
>> > "the support MFP support" ??

Sorry for the typo...

>> >
>> > Please fix. Also, please explain what MFP is. It may be obvious to
>> > you, it ain't so for me.

MFP is stand for multiply function pin setting, which servers for
setting a pin of cpu to server for different
functions on different design boards to better suit for its design.

Best regards,
Lei
Lei Wen - Jan. 26, 2011, 7:51 a.m.
Hi Wolfgang,

On Wed, Jan 26, 2011 at 3:44 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Lei Wen,
>
> In message <AANLkTikKdESNw=7bnpcR8Yr8TZtD=Q=MmGGNd9ELJBBj@mail.gmail.com> you wrote:
>>
>> This already fixed in the v6 patch, maybe you didn't notice this...
>
> Yes, I missed this v6 series of patches, because it seems you broke
> the mail thread when sending it.
>
> Please see
> http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
> bullet # 3.
>

I have a question for this rule...
When I use the git-send-email to send the whole patch set, it only ask
me to input only one reference message id.
Then how this reference message id get? The previous cover letter
message id? Or just send the new patch set
one patch by one patch with each previous message id?

Best regards,
Lei
Wolfgang Denk - Jan. 26, 2011, 8:06 a.m.
Dear Lei Wen,

In message <AANLkTinN07gFCXTGqBVSAyQM_BDXJ6xq0+OzPmh+_DAb@mail.gmail.com> you wrote:
> 
> >> > Please fix. Also, please explain what MFP is. It may be obvious to
> >> > you, it ain't so for me.
> 
> MFP is stand for multiply function pin setting, which servers for
> setting a pin of cpu to server for different
> functions on different design boards to better suit for its design.

multiply or multiple?

Maybe you can write something like "Add support for multiple function
pin (MFP) for Marvell PANTHEON SoCs" in your commit message.

Otherwise people might wonder what Multi Function Peripherals or Multi
Function Printers have to do with that.

Best regards,

Wolfgang Denk
Wolfgang Denk - Jan. 26, 2011, 8:07 a.m.
Dear Lei Wen,

In message <AANLkTi=e2gB4nPwtcT3Aa_g2BAZZ_Nk5ca+8nbVCRe2Y@mail.gmail.com> you wrote:
> 
> I have a question for this rule...
> When I use the git-send-email to send the whole patch set, it only ask
> me to input only one reference message id.
> Then how this reference message id get? The previous cover letter
> message id? ...

Yes, exactly.

> one patch by one patch with each previous message id?

No.

Thanks.

Best regards,

Wolfgang Denk
Lei Wen - Jan. 26, 2011, 8:08 a.m.
Hi Wolfgang,

On Wed, Jan 26, 2011 at 4:06 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Lei Wen,
>
> In message <AANLkTinN07gFCXTGqBVSAyQM_BDXJ6xq0+OzPmh+_DAb@mail.gmail.com> you wrote:
>>
>> >> > Please fix. Also, please explain what MFP is. It may be obvious to
>> >> > you, it ain't so for me.
>>
>> MFP is stand for multiply function pin setting, which servers for
>> setting a pin of cpu to server for different
>> functions on different design boards to better suit for its design.
>
> multiply or multiple?

Sorry for my poor English. It is multiple.
>
> Maybe you can write something like "Add support for multiple function
> pin (MFP) for Marvell PANTHEON SoCs" in your commit message.
>
> Otherwise people might wonder what Multi Function Peripherals or Multi
> Function Printers have to do with that.
>

Agree. Fix it in next patch set...

Best regards,
Lei
Lei Wen - Jan. 26, 2011, 8:09 a.m.
On Wed, Jan 26, 2011 at 4:07 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Lei Wen,
>
> In message <AANLkTi=e2gB4nPwtcT3Aa_g2BAZZ_Nk5ca+8nbVCRe2Y@mail.gmail.com> you wrote:
>>
>> I have a question for this rule...
>> When I use the git-send-email to send the whole patch set, it only ask
>> me to input only one reference message id.
>> Then how this reference message id get? The previous cover letter
>> message id? ...
>
> Yes, exactly.

Got it...

Best regards,
Lei

Patch

diff --git a/arch/arm/include/asm/arch-pantheon/mfp.h b/arch/arm/include/asm/arch-pantheon/mfp.h
new file mode 100644
index 0000000..ad1ed03
--- /dev/null
+++ b/arch/arm/include/asm/arch-pantheon/mfp.h
@@ -0,0 +1,42 @@ 
+/*
+ * Based on arch/arm/include/asm/arch-armada100/mfp.h
+ * (C) Copyright 2010
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Lei Wen <leiwen@marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301 USA
+ */
+
+#ifndef __PANTHEON_MFP_H
+#define __PANTHEON_MFP_H
+
+/*
+ * Frequently used MFP Configuration macros for all PANTHEON family of
+SoCs
+ *
+ * offset, pull,pF, drv,dF, edge,eF ,afn,aF
+ */
+/* UART2 */
+#define MFP47_UART2_RXD		MFP_REG(0x198) | MFP_AF6 | MFP_DRIVE_MEDIUM
+#define MFP48_UART2_TXD		MFP_REG(0x19c) | MFP_AF6 | MFP_DRIVE_MEDIUM
+
+/* More macros can be defined here... */
+
+#define MFP_PIN_MAX	117
+#endif
diff --git a/drivers/gpio/mvmfp.c b/drivers/gpio/mvmfp.c
index 5646ed4..e7830c6 100644
--- a/drivers/gpio/mvmfp.c
+++ b/drivers/gpio/mvmfp.c
@@ -28,6 +28,8 @@ 
 #include <asm/arch/mfp.h>
 #ifdef CONFIG_ARMADA100
 #include <asm/arch/armada100.h>
+#elif defined(CONFIG_PANTHEON)
+#include <asm/arch/pantheon.h>
 #else
 #error Unsupported SoC...
 #endif