| Message ID | 20170626112939.25355-1-sysugaozhenyu@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
ping.... Thanks Zhenyu Gao 2017-06-26 19:29 GMT+08:00 Zhenyu Gao <sysugaozhenyu@gmail.com>: > The element of rx_1024_to_1522_packets has wrong > name(rx_1024_to_1518_packets). > Change it from rx_1024_to_1518_packets to rx_1024_to_1522_packets, it > should > record packets between 1024 to 1522. > > The element of tx_1024_to_1522_packets has wrong > name(tx_1024_to_1518_packets). > Change it from tx_1024_to_1518_packets to tx_1024_to_1522_packets, it > should > record packets between 1024 to 1522. > > Signed-off-by: Zhenyu Gao <sysugaozhenyu@gmail.com> > --- > vswitchd/bridge.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index 8336d70..b9fb8e6 100644 > --- a/vswitchd/bridge.c > +++ b/vswitchd/bridge.c > @@ -2369,14 +2369,14 @@ iface_refresh_stats(struct iface *iface) > IFACE_STAT(rx_128_to_255_packets, "rx_128_to_255_packets") \ > IFACE_STAT(rx_256_to_511_packets, "rx_256_to_511_packets") \ > IFACE_STAT(rx_512_to_1023_packets, "rx_512_to_1023_packets") \ > - IFACE_STAT(rx_1024_to_1522_packets, "rx_1024_to_1518_packets") \ > + IFACE_STAT(rx_1024_to_1522_packets, "rx_1024_to_1522_packets") \ > IFACE_STAT(rx_1523_to_max_packets, "rx_1523_to_max_packets") \ > IFACE_STAT(tx_1_to_64_packets, "tx_1_to_64_packets") \ > IFACE_STAT(tx_65_to_127_packets, "tx_65_to_127_packets") \ > IFACE_STAT(tx_128_to_255_packets, "tx_128_to_255_packets") \ > IFACE_STAT(tx_256_to_511_packets, "tx_256_to_511_packets") \ > IFACE_STAT(tx_512_to_1023_packets, "tx_512_to_1023_packets") \ > - IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1518_packets") \ > + IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1522_packets") \ > IFACE_STAT(tx_1523_to_max_packets, "tx_1523_to_max_packets") \ > IFACE_STAT(tx_multicast_packets, "tx_multicast_packets") \ > IFACE_STAT(rx_broadcast_packets, "rx_broadcast_packets") \ > -- > 1.8.3.1 > >
On Mon, Jun 26, 2017 at 12:29 PM, Zhenyu Gao <sysugaozhenyu@gmail.com> wrote: > The element of rx_1024_to_1522_packets has wrong name(rx_1024_to_1518_packets). > Change it from rx_1024_to_1518_packets to rx_1024_to_1522_packets, it should > record packets between 1024 to 1522. > > The element of tx_1024_to_1522_packets has wrong name(tx_1024_to_1518_packets). > Change it from tx_1024_to_1518_packets to tx_1024_to_1522_packets, it should > record packets between 1024 to 1522. > > Signed-off-by: Zhenyu Gao <sysugaozhenyu@gmail.com> > --- > vswitchd/bridge.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index 8336d70..b9fb8e6 100644 > --- a/vswitchd/bridge.c > +++ b/vswitchd/bridge.c > @@ -2369,14 +2369,14 @@ iface_refresh_stats(struct iface *iface) > IFACE_STAT(rx_128_to_255_packets, "rx_128_to_255_packets") \ > IFACE_STAT(rx_256_to_511_packets, "rx_256_to_511_packets") \ > IFACE_STAT(rx_512_to_1023_packets, "rx_512_to_1023_packets") \ > - IFACE_STAT(rx_1024_to_1522_packets, "rx_1024_to_1518_packets") \ > + IFACE_STAT(rx_1024_to_1522_packets, "rx_1024_to_1522_packets") \ > IFACE_STAT(rx_1523_to_max_packets, "rx_1523_to_max_packets") \ > IFACE_STAT(tx_1_to_64_packets, "tx_1_to_64_packets") \ > IFACE_STAT(tx_65_to_127_packets, "tx_65_to_127_packets") \ > IFACE_STAT(tx_128_to_255_packets, "tx_128_to_255_packets") \ > IFACE_STAT(tx_256_to_511_packets, "tx_256_to_511_packets") \ > IFACE_STAT(tx_512_to_1023_packets, "tx_512_to_1023_packets") \ > - IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1518_packets") \ > + IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1522_packets") \ > IFACE_STAT(tx_1523_to_max_packets, "tx_1523_to_max_packets") \ > IFACE_STAT(tx_multicast_packets, "tx_multicast_packets") \ > IFACE_STAT(rx_broadcast_packets, "rx_broadcast_packets") \ It does appear that this fixes a hole between 1518 and 1522 where packets sized 1519 to 1522 would not be handled properly. Reviewed-by: Greg Rose <gvrose8192@gmail.com> > -- > 1.8.3.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 8336d70..b9fb8e6 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -2369,14 +2369,14 @@ iface_refresh_stats(struct iface *iface) IFACE_STAT(rx_128_to_255_packets, "rx_128_to_255_packets") \ IFACE_STAT(rx_256_to_511_packets, "rx_256_to_511_packets") \ IFACE_STAT(rx_512_to_1023_packets, "rx_512_to_1023_packets") \ - IFACE_STAT(rx_1024_to_1522_packets, "rx_1024_to_1518_packets") \ + IFACE_STAT(rx_1024_to_1522_packets, "rx_1024_to_1522_packets") \ IFACE_STAT(rx_1523_to_max_packets, "rx_1523_to_max_packets") \ IFACE_STAT(tx_1_to_64_packets, "tx_1_to_64_packets") \ IFACE_STAT(tx_65_to_127_packets, "tx_65_to_127_packets") \ IFACE_STAT(tx_128_to_255_packets, "tx_128_to_255_packets") \ IFACE_STAT(tx_256_to_511_packets, "tx_256_to_511_packets") \ IFACE_STAT(tx_512_to_1023_packets, "tx_512_to_1023_packets") \ - IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1518_packets") \ + IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1522_packets") \ IFACE_STAT(tx_1523_to_max_packets, "tx_1523_to_max_packets") \ IFACE_STAT(tx_multicast_packets, "tx_multicast_packets") \ IFACE_STAT(rx_broadcast_packets, "rx_broadcast_packets") \
The element of rx_1024_to_1522_packets has wrong name(rx_1024_to_1518_packets). Change it from rx_1024_to_1518_packets to rx_1024_to_1522_packets, it should record packets between 1024 to 1522. The element of tx_1024_to_1522_packets has wrong name(tx_1024_to_1518_packets). Change it from tx_1024_to_1518_packets to tx_1024_to_1522_packets, it should record packets between 1024 to 1522. Signed-off-by: Zhenyu Gao <sysugaozhenyu@gmail.com> --- vswitchd/bridge.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)