From patchwork Sun Jan 9 00:27:33 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jack Howarth X-Patchwork-Id: 77995 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3E99BB70F6 for ; Sun, 9 Jan 2011 11:27:43 +1100 (EST) Received: (qmail 2053 invoked by alias); 9 Jan 2011 00:27:41 -0000 Received: (qmail 2045 invoked by uid 22791); 9 Jan 2011 00:27:40 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL, BAYES_00, TW_GX, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 09 Jan 2011 00:27:36 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id 292CCB0074; Sat, 8 Jan 2011 19:27:34 -0500 (EST) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id p090RXlR001359; Sat, 8 Jan 2011 19:27:33 -0500 Date: Sat, 8 Jan 2011 19:27:33 -0500 From: Jack Howarth To: Tobias Grosser Cc: gcc-graphite@googlegroups.com, Gerald Pfeifer , gcc-patches@gcc.gnu.org, Sebastian Pop Subject: Re: [PATCH] * doc/install.texi: Document availability of cloog-0.16 Message-ID: <20110109002733.GA1326@bromo.med.uc.edu> References: <1294250132-30205-1-git-send-email-grosser@fim.uni-passau.de> <4D269405.5080409@fim.uni-passau.de> <4D288676.1@fim.uni-passau.de> <20110108203549.GA32618@bromo.med.uc.edu> <20110108225224.GA837@bromo.med.uc.edu> <4D28EEB7.7020104@fim.uni-passau.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4D28EEB7.7020104@fim.uni-passau.de> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Sat, Jan 08, 2011 at 06:09:43PM -0500, Tobias Grosser wrote: > On 01/08/2011 05:52 PM, Jack Howarth wrote: >> On Sat, Jan 08, 2011 at 03:35:49PM -0500, Jack Howarth wrote: >>> On Sat, Jan 08, 2011 at 10:44:54AM -0500, Tobias Grosser wrote: >>>> On 01/08/2011 07:10 AM, Gerald Pfeifer wrote: >>>>> On Thu, 6 Jan 2011, Tobias Grosser wrote: >>>>>> thanks for the comments. I just added information to that install.texi >>>>>> file, which made it really hard to read. I now tried to restructure >>>>>> the whole comment and hope it became easier to read. >>>>> >>>>> Definitely, thanks a lot. Now I managed to parse this just fine. ;-) >>>>> >>>>> Mind the long lines and break them, otherwise this looks good. >>>> >>>> OK. Thanks. >>>> >>>> I will commit this as soon as the related CLooG packages are uploaded. >>>> >>>> Cheers >>>> Tobi >>> >>> Tobi, >>> I am confused by the configure code that sets CFLAGS to -O1 when >>> gcc 4.2.x is in use. Reverting this change on x86_64-apple-darwin10 >>> still allows cloog 0.16.1 to build on x86_64-apple-darwin10 without >>> any regressions in the cloog testsuite. This is built against the >>> gcc 4.2.1 compiler in Xcode 3.2.5. I also find that building against >>> gcc-4.2 and g++-4.2 from Xcode 3.1.4 under powerpc-apple-darwin9 >>> produces no cloog testsuite failures. Perhaps the cloog/isl/configure >>> test could be enhanced to not set -O1 if the gcc 4.2.x is "Apple Inc. build" >>> since Apple uses a very forked branch of gcc 4.2.1... >>> >>> gcc -v >>> Using built-in specs. >>> Target: i686-apple-darwin10 >>> Configured with: /var/tmp/gcc/gcc-5664~89/src/configure --disable-checking --enable-werror --prefix=/usr --mandir=/share/man --enable-languages=c,objc,c++,obj-c++ --program-transform-name=/^[cg][^.-]*$/s/$/-4.2/ --with-slibdir=/usr/lib --build=i686-apple-darwin10 --program-prefix=i686-apple-darwin10- --host=x86_64-apple-darwin10 --target=i686-apple-darwin10 --with-gxx-include-dir=/include/c++/4.2.1 >>> Thread model: posix >>> gcc version 4.2.1 (Apple Inc. build 5664) >>> >>> I'll test current gcc trunk built with -enable-cloog-backend=isl against >>> a -O3 isl build to check for regressions in graphite. >>> Jack >> >> Tobi, >> A build of current gcc trunk with -enable-cloog-backend=isl against cloog 0.16.1 built >> entirely at -O3 shows no regressions in the graphite.exp tests on x86_64-apple-darwin10. >> So it seems unnecessary to resort to -O1 in the isl build within cloog when Apple's >> gcc 4.2.1 is in use. >> Jack > > Hi Jack, > > thanks for testing. Even if I am not sure that the graphite test suite > is large enough to find all subtile bugs, but in case of Apple's gcc > 4.2.1 it is probably save to assume it is not a gcc 4.2.1 any more. Do > you think you could provide a patch for Cloog that implements your > suggestions, such that Sven can include it in the next Cloog release. > > Thanks a lot > Tobi Tobi, The simplest fix would be... so that the test is short-circuited on Apple's compiler builds. Applying this change directly to isl/configure, I've confirmed that this properly applies -O1 for a GNU gcc 4.2 compiler and not for Apple's compilers. Jack --- isl/m4/ax_cc_maxopt.m4.org 2011-01-08 18:12:56.000000000 -0500 +++ isl/m4/ax_cc_maxopt.m4 2011-01-08 19:20:53.000000000 -0500 @@ -151,7 +151,7 @@ AX_GCC_ARCHFLAG($acx_maxopt_portable) # drop to -O1 for gcc 4.2 - $CC --version | + $CC --version | grep -v 'Apple Inc' | sed -e 's/.* \(@<:@0-9@:>@@<:@0-9@:>@*\)\.\(@<:@0-9@:>@@<:@0-9@:>@*\).*/\1 \2/' | (read major minor if test $major -eq 4 -a $minor -eq 2; then