diff mbox

[U-Boot,1/1] armv8: ls2080a: Increase env size for qspi boot

Message ID 1498212627-18230-1-git-send-email-santan.kumar@nxp.com
State Changes Requested
Delegated to: York Sun
Headers show

Commit Message

Santan Kumar June 23, 2017, 10:10 a.m. UTC 
Increase env size from 64kb to 256kb for qspi boot

Signed-off-by: Santan Kumar <santan.kumar@nxp.com>
Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
---
This patch is split version of another patch
 https://patchwork.ozlabs.org/patch/773670/

 include/configs/ls2080a_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

York Sun Aug. 8, 2017, 5:56 p.m. UTC | #1 
On 06/23/2017 03:07 AM, Santan Kumar wrote:
> Increase env size from 64kb to 256kb for qspi boot
> 
> Signed-off-by: Santan Kumar <santan.kumar@nxp.com>
> Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
> ---
> This patch is split version of another patch
>   https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F773670%2F&data=01%7C01%7Cyork.sun%40nxp.com%7Cf71f395a0cb94adb322b08d4ba1fb900%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=%2FvMEmB84i5peyUh4JMHi6k%2Fc5cm76x1JMftBeLSANWc%3D&reserved=0
> 
>   include/configs/ls2080a_common.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/configs/ls2080a_common.h b/include/configs/ls2080a_common.h
> index e311d0b..68191f2 100644
> --- a/include/configs/ls2080a_common.h
> +++ b/include/configs/ls2080a_common.h
> @@ -34,7 +34,7 @@
>   #define CONFIG_ENV_IS_IN_SPI_FLASH
>   #define CONFIG_ENV_SIZE			0x2000          /* 8KB */
>   #define CONFIG_ENV_OFFSET		0x300000        /* 3MB */
> -#define CONFIG_ENV_SECT_SIZE		0x10000
> +#define CONFIG_ENV_SECT_SIZE		0x40000
>   #endif
>   
>   #define CONFIG_SUPPORT_RAW_INITRD
> 


Santan,

You are increasing the sector size, not the env size. Is this what you 
intend to do?

York
Santan Kumar Aug. 9, 2017, 4:21 a.m. UTC | #2 
> -----Original Message-----
> From: York Sun
> Sent: Tuesday, August 08, 2017 11:26 PM
> To: Santan Kumar <santan.kumar@nxp.com>; u-boot@lists.denx.de
> Cc: Priyanka Jain <priyanka.jain@nxp.com>
> Subject: Re: [PATCH 1/1] armv8: ls2080a: Increase env size for qspi boot
> 
> On 06/23/2017 03:07 AM, Santan Kumar wrote:
> > Increase env size from 64kb to 256kb for qspi boot
> >
> > Signed-off-by: Santan Kumar <santan.kumar@nxp.com>
> > Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
> > ---
> > This patch is split version of another patch
> >
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> >
> chwork.ozlabs.org%2Fpatch%2F773670%2F&data=01%7C01%7Cyork.sun%40
> nxp.co
> >
> m%7Cf71f395a0cb94adb322b08d4ba1fb900%7C686ea1d3bc2b4c6fa92cd99c5c
> 30163
> >
> 5%7C0&sdata=%2FvMEmB84i5peyUh4JMHi6k%2Fc5cm76x1JMftBeLSANWc%
> 3D&reserve
> > d=0
> >
> >   include/configs/ls2080a_common.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/configs/ls2080a_common.h
> > b/include/configs/ls2080a_common.h
> > index e311d0b..68191f2 100644
> > --- a/include/configs/ls2080a_common.h
> > +++ b/include/configs/ls2080a_common.h
> > @@ -34,7 +34,7 @@
> >   #define CONFIG_ENV_IS_IN_SPI_FLASH
> >   #define CONFIG_ENV_SIZE			0x2000          /* 8KB */
> >   #define CONFIG_ENV_OFFSET		0x300000        /* 3MB */
> > -#define CONFIG_ENV_SECT_SIZE		0x10000
> > +#define CONFIG_ENV_SECT_SIZE		0x40000
> >   #endif
> >
> >   #define CONFIG_SUPPORT_RAW_INITRD
> >
> 
> 
> Santan,
> 
> You are increasing the sector size, not the env size. Is this what you intend to
> do?
> 
> York

[Santan] Yes, my intent is to increase the sector size, because the env erase will work in the multiple of 
	256kb. If you want I can change the commit message.
York Sun Aug. 9, 2017, 4:41 a.m. UTC | #3 
> On Aug 8, 2017, at 21:21, Santan Kumar <santan.kumar@nxp.com> wrote:
> 
> 
> 
>> -----Original Message-----
>> From: York Sun
>> Sent: Tuesday, August 08, 2017 11:26 PM
>> To: Santan Kumar <santan.kumar@nxp.com>; u-boot@lists.denx.de
>> Cc: Priyanka Jain <priyanka.jain@nxp.com>
>> Subject: Re: [PATCH 1/1] armv8: ls2080a: Increase env size for qspi boot
>> 
>>> On 06/23/2017 03:07 AM, Santan Kumar wrote:
>>> Increase env size from 64kb to 256kb for qspi boot
>>> 
>>> Signed-off-by: Santan Kumar <santan.kumar@nxp.com>
>>> Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
>>> ---
>>> This patch is split version of another patch
>>> 
>>> 
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
>>> 
>> chwork.ozlabs.org%2Fpatch%2F773670%2F&data=01%7C01%7Cyork.sun%40
>> nxp.co
>>> 
>> m%7Cf71f395a0cb94adb322b08d4ba1fb900%7C686ea1d3bc2b4c6fa92cd99c5c
>> 30163
>>> 
>> 5%7C0&sdata=%2FvMEmB84i5peyUh4JMHi6k%2Fc5cm76x1JMftBeLSANWc%
>> 3D&reserve
>>> d=0
>>> 
>>>  include/configs/ls2080a_common.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/include/configs/ls2080a_common.h
>>> b/include/configs/ls2080a_common.h
>>> index e311d0b..68191f2 100644
>>> --- a/include/configs/ls2080a_common.h
>>> +++ b/include/configs/ls2080a_common.h
>>> @@ -34,7 +34,7 @@
>>>  #define CONFIG_ENV_IS_IN_SPI_FLASH
>>>  #define CONFIG_ENV_SIZE            0x2000          /* 8KB */
>>>  #define CONFIG_ENV_OFFSET        0x300000        /* 3MB */
>>> -#define CONFIG_ENV_SECT_SIZE        0x10000
>>> +#define CONFIG_ENV_SECT_SIZE        0x40000
>>>  #endif
>>> 
>>>  #define CONFIG_SUPPORT_RAW_INITRD
>>> 
>> 
>> 
>> Santan,
>> 
>> You are increasing the sector size, not the env size. Is this what you intend to
>> do?
>> 
>> York
> 
> [Santan] Yes, my intent is to increase the sector size, because the env erase will work in the multiple of 
>    256kb. If you want I can change the commit message.

Please resend with fixed subject and commit message. Thanks. 

York
diff mbox

Patch

diff --git a/include/configs/ls2080a_common.h b/include/configs/ls2080a_common.h
index e311d0b..68191f2 100644
--- a/include/configs/ls2080a_common.h
+++ b/include/configs/ls2080a_common.h
@@ -34,7 +34,7 @@ 
 #define CONFIG_ENV_IS_IN_SPI_FLASH
 #define CONFIG_ENV_SIZE			0x2000          /* 8KB */
 #define CONFIG_ENV_OFFSET		0x300000        /* 3MB */
-#define CONFIG_ENV_SECT_SIZE		0x10000
+#define CONFIG_ENV_SECT_SIZE		0x40000
 #endif
 
 #define CONFIG_SUPPORT_RAW_INITRD