From patchwork Sat Jan 8 23:25:06 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: MTD: FTL layer: don't free input argument in add_mtd_blktrans_dev From: Maxim Levitsky X-Patchwork-Id: 77992 Message-Id: <1294529106-32586-1-git-send-email-maximlevitsky@gmail.com> To: linux-mtd@lists.infradead.org Cc: enh@google.com, David Woodhouse , Maxim Levitsky , nnk@google.com Date: Sun, 9 Jan 2011 01:25:06 +0200 This one liner patch fixes double free that will occur if add_mtd_blktrans_dev fails. On failure it free input argument, but all its users also free it on error which is natural thing to do. Thus don't free it. All credit for finding that bug belongs to reporters of the bug in the android bugzilla http://code.google.com/p/android/issues/detail?id=13761 Signed-of-by: Maxim Levitsky CC: nnk@google.com CC: enh@google.com --- drivers/mtd/mtd_blkdevs.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/mtd/mtd_blkdevs.c b/drivers/mtd/mtd_blkdevs.c index cb20c67..e0a2373 100644 --- a/drivers/mtd/mtd_blkdevs.c +++ b/drivers/mtd/mtd_blkdevs.c @@ -413,7 +413,6 @@ error3: error2: list_del(&new->list); error1: - kfree(new); return ret; }