diff mbox

rtc: rtc-nuc900: fix loop timeout test

Message ID 20170623082900.GB7922@elgon.mountain
State Accepted
Headers show

Commit Message

Dan Carpenter June 23, 2017, 8:29 a.m. UTC 
We should change this post-op to a pre-op because we want the loop to
exit with "timeout" set to zero.

Fixes: 0a89b55364e0 ("nuc900/rtc: change the waiting for device ready implement")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Alexandre Belloni July 5, 2017, 9:09 p.m. UTC | #1 
On 23/06/2017 at 11:29:00 +0300, Dan Carpenter wrote:
> We should change this post-op to a pre-op because we want the loop to
> exit with "timeout" set to zero.
> 
> Fixes: 0a89b55364e0 ("nuc900/rtc: change the waiting for device ready implement")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
Applied, thanks.
diff mbox

Patch

diff --git a/drivers/rtc/rtc-nuc900.c b/drivers/rtc/rtc-nuc900.c
index b1b6b3041bfb..4ed81117cf5f 100644
--- a/drivers/rtc/rtc-nuc900.c
+++ b/drivers/rtc/rtc-nuc900.c
@@ -93,7 +93,7 @@  static int *check_rtc_access_enable(struct nuc900_rtc *nuc900_rtc)
 	__raw_writel(AERPOWERON, nuc900_rtc->rtc_reg + REG_RTC_AER);
 
 	while (!(__raw_readl(nuc900_rtc->rtc_reg + REG_RTC_AER) & AERRWENB)
-								&& timeout--)
+								&& --timeout)
 		mdelay(1);
 
 	if (!timeout)