diff mbox

[2/3] acpi: hest: fix typo for type 7

Message ID 1498175437-27584-2-git-send-email-alex.hung@canonical.com
State Accepted
Headers show

Commit Message

Alex Hung June 22, 2017, 11:50 p.m. UTC 
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/acpi/hest/hest.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Colin Ian King June 23, 2017, 8:10 a.m. UTC | #1 
On 23/06/17 00:50, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/hest/hest.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/acpi/hest/hest.c b/src/acpi/hest/hest.c
> index 4d10726..109f1e3 100644
> --- a/src/acpi/hest/hest.c
> +++ b/src/acpi/hest/hest.c
> @@ -483,16 +483,16 @@ static void hest_check_pci_express_device_aer(
>  	if (aer->flags & ~0x3) {
>  		*passed = false;
>  		fwts_failed(fw, LOG_LEVEL_MEDIUM,
> -			"HESTPciExpressRootPortFlagsReserved",
> -			"HEST PCI Express Root Port Flags Reserved bits "
> +			"HESTPciExpressDeviceFlagsReserved",
> +			"HEST PCI Express Device Flags Reserved bits "
>  			"[2:7] must be zero, instead got 0x%" PRIx8,
>  			aer->flags);
>  	}
>  	if (aer->reserved2) {
>  		*passed = false;
>  		fwts_failed(fw, LOG_LEVEL_LOW,
> -			"HESTPciExpressRootPortReservedNonZero",
> -			"HEST PCI Express Root Port Reserved field "
> +			"HESTPciExpressDeviceReservedNonZero",
> +			"HEST PCI Express Device Reserved field "
>  			"at offset 26 must be zero, instead got 0x%" PRIx16,
>  			aer->reserved2);
>  	}
> @@ -500,7 +500,7 @@ static void hest_check_pci_express_device_aer(
>  		*passed = false;
>  		fwts_failed(fw, LOG_LEVEL_HIGH,
>  			"HESTInvalidRecordsToPreallocate",
> -			"HEST PCI Express Root Port Number of Records "
> +			"HEST PCI Express Device Number of Records "
>  			"to Preallocate is 0x%" PRIx16 " and must be "
>  			"more than zero.",
>  			aer->number_of_records_to_preallocate);
> @@ -509,7 +509,7 @@ static void hest_check_pci_express_device_aer(
>  		*passed = false;
>  		fwts_failed(fw, LOG_LEVEL_HIGH,
>  			"HESTInvalidMaxSectionsPerRecord",
> -			"HEST PCI Express Root Port Max Sections Per "
> +			"HEST PCI Express Device Max Sections Per "
>  			"Record is 0x%" PRIx16 " and must be "
>  			"more than zero.",
>  			aer->max_sections_per_record);
> 
Good catch!

Acked-by: Colin Ian King <colin.king@canonical.com>
Ivan Hu June 26, 2017, 9:44 a.m. UTC | #2 
On 06/23/2017 07:50 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/acpi/hest/hest.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/acpi/hest/hest.c b/src/acpi/hest/hest.c
> index 4d10726..109f1e3 100644
> --- a/src/acpi/hest/hest.c
> +++ b/src/acpi/hest/hest.c
> @@ -483,16 +483,16 @@ static void hest_check_pci_express_device_aer(
>   	if (aer->flags & ~0x3) {
>   		*passed = false;
>   		fwts_failed(fw, LOG_LEVEL_MEDIUM,
> -			"HESTPciExpressRootPortFlagsReserved",
> -			"HEST PCI Express Root Port Flags Reserved bits "
> +			"HESTPciExpressDeviceFlagsReserved",
> +			"HEST PCI Express Device Flags Reserved bits "
>   			"[2:7] must be zero, instead got 0x%" PRIx8,
>   			aer->flags);
>   	}
>   	if (aer->reserved2) {
>   		*passed = false;
>   		fwts_failed(fw, LOG_LEVEL_LOW,
> -			"HESTPciExpressRootPortReservedNonZero",
> -			"HEST PCI Express Root Port Reserved field "
> +			"HESTPciExpressDeviceReservedNonZero",
> +			"HEST PCI Express Device Reserved field "
>   			"at offset 26 must be zero, instead got 0x%" PRIx16,
>   			aer->reserved2);
>   	}
> @@ -500,7 +500,7 @@ static void hest_check_pci_express_device_aer(
>   		*passed = false;
>   		fwts_failed(fw, LOG_LEVEL_HIGH,
>   			"HESTInvalidRecordsToPreallocate",
> -			"HEST PCI Express Root Port Number of Records "
> +			"HEST PCI Express Device Number of Records "
>   			"to Preallocate is 0x%" PRIx16 " and must be "
>   			"more than zero.",
>   			aer->number_of_records_to_preallocate);
> @@ -509,7 +509,7 @@ static void hest_check_pci_express_device_aer(
>   		*passed = false;
>   		fwts_failed(fw, LOG_LEVEL_HIGH,
>   			"HESTInvalidMaxSectionsPerRecord",
> -			"HEST PCI Express Root Port Max Sections Per "
> +			"HEST PCI Express Device Max Sections Per "
>   			"Record is 0x%" PRIx16 " and must be "
>   			"more than zero.",
>   			aer->max_sections_per_record);
> 
Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/src/acpi/hest/hest.c b/src/acpi/hest/hest.c
index 4d10726..109f1e3 100644
--- a/src/acpi/hest/hest.c
+++ b/src/acpi/hest/hest.c
@@ -483,16 +483,16 @@  static void hest_check_pci_express_device_aer(
 	if (aer->flags & ~0x3) {
 		*passed = false;
 		fwts_failed(fw, LOG_LEVEL_MEDIUM,
-			"HESTPciExpressRootPortFlagsReserved",
-			"HEST PCI Express Root Port Flags Reserved bits "
+			"HESTPciExpressDeviceFlagsReserved",
+			"HEST PCI Express Device Flags Reserved bits "
 			"[2:7] must be zero, instead got 0x%" PRIx8,
 			aer->flags);
 	}
 	if (aer->reserved2) {
 		*passed = false;
 		fwts_failed(fw, LOG_LEVEL_LOW,
-			"HESTPciExpressRootPortReservedNonZero",
-			"HEST PCI Express Root Port Reserved field "
+			"HESTPciExpressDeviceReservedNonZero",
+			"HEST PCI Express Device Reserved field "
 			"at offset 26 must be zero, instead got 0x%" PRIx16,
 			aer->reserved2);
 	}
@@ -500,7 +500,7 @@  static void hest_check_pci_express_device_aer(
 		*passed = false;
 		fwts_failed(fw, LOG_LEVEL_HIGH,
 			"HESTInvalidRecordsToPreallocate",
-			"HEST PCI Express Root Port Number of Records "
+			"HEST PCI Express Device Number of Records "
 			"to Preallocate is 0x%" PRIx16 " and must be "
 			"more than zero.",
 			aer->number_of_records_to_preallocate);
@@ -509,7 +509,7 @@  static void hest_check_pci_express_device_aer(
 		*passed = false;
 		fwts_failed(fw, LOG_LEVEL_HIGH,
 			"HESTInvalidMaxSectionsPerRecord",
-			"HEST PCI Express Root Port Max Sections Per "
+			"HEST PCI Express Device Max Sections Per "
 			"Record is 0x%" PRIx16 " and must be "
 			"more than zero.",
 			aer->max_sections_per_record);