From patchwork Thu Jun 22 07:40:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlo Lobrano X-Patchwork-Id: 779375 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wtYRF2HD6z9sBR for ; Thu, 22 Jun 2017 17:40:56 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="R1Z6MAUb"; dkim-atps=neutral Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 9A6A9B8081C; Thu, 22 Jun 2017 09:40:47 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.1 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP; Thu, 22 Jun 2017 09:40:47 +0200 (CEST) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id D941FB8004E for ; Thu, 22 Jun 2017 09:40:46 +0200 (CEST) X-policyd-weight: using cached result; rate: -7 Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Thu, 22 Jun 2017 09:40:45 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id 77so11405978wrb.1 for ; Thu, 22 Jun 2017 00:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=L9Wm01IdR0iY0G0zQUqZ32KnzmssijZN3vILXYP16MI=; b=R1Z6MAUblEwLuoSs2Tf+sZcj3Hk7v2JiyP0M70G7NqbguygmYEJv8YqaT+6J6wMe7i 6nYADJNXxqUik+UuFMBMYzBNUzl9NWJxHUF+u0lseCrfyTIYNQ+IJsChgqqxBka5IG4x vPlP6XRMis2olgL4uAFsTMcLehwUbRSTr12pI/dqotzXVSxqfWvx34WjnrOB+GgOEPuV gyNUKl9EPNnrzjBNNpdsMnG/dO6FO2FH2hJUC3CaYsHUAG08/qUZhh5qV1NnUrd34P3J UIwRA+tGaRUENk/AGYy1xggZ40chrvapDIZ4XInoK+Ye3LqGywu/A/U1aUYWWsx7XQSw SwvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=L9Wm01IdR0iY0G0zQUqZ32KnzmssijZN3vILXYP16MI=; b=kMCNoSD1YLcqnuKVdCQrCaKpdmh3GaAOpAkQNYNYtJMbHWfaGWUQYAbaQuZgzLSeHD 2uz68TZbwyT4+VIlORdcMjFICMKJKuDHa7oCspB5Cuz0oEvQkdI/GdRYqYOLQTWYijCT DOoARy9f0nmaG4ea1sQly7VjFhwA2yknkFsTZH4fH5GUW1LsWuvte+UWm9taKAGqcHfE x5sTLLI5p3LsCfkxa+JUJ7SfJ9iV2kC8MBgh61bjxGouP2jzghm/4pnvYfCludIRkQLz UJE8V4lLi8S6LlPPd2NguOuV8Waftp4HQUHfVHN5sRTAoI7uEjMGy4t+QDw5AEswKC6f ajsw== X-Gm-Message-State: AKS2vOxtNamzbYmvqW44jRZ/Dx6J6fGcqGFfpc05NgqArLvmPzf2jFPL 6vgfKhRE/uT+ALzI X-Received: by 10.28.196.142 with SMTP id u136mr650913wmf.25.1498117244743; Thu, 22 Jun 2017 00:40:44 -0700 (PDT) Received: from d2092.tmt.telital.com ([213.205.6.118]) by smtp.gmail.com with ESMTPSA id z99sm1427526wrc.12.2017.06.22.00.40.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jun 2017 00:40:43 -0700 (PDT) From: Carlo Lobrano To: Date: Thu, 22 Jun 2017 09:40:37 +0200 Message-Id: <20170622074037.14512-1-c.lobrano@gmail.com> X-Mailer: git-send-email 2.9.3 Subject: [OpenWrt-Devel] [PATCH] uqmi_add_command: fixed command argument assignment X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" The char *arg passed to uqmi_add_command was not assigned to cmd[idx].arg. --- Hi, I saw this little bug. Hope this is the right place to submit the patch Best regards, Carlo --- commands.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/commands.c b/commands.c index f9545a9..8e9810d 100644 --- a/commands.c +++ b/commands.c @@ -193,7 +193,7 @@ void uqmi_add_command(char *arg, int cmd) cmds = realloc(cmds, n_cmds * sizeof(*cmds)); cmds[idx].handler = &uqmi_cmd_handler[cmd]; - cmds[idx].arg = optarg; + cmds[idx].arg = arg; } static void uqmi_print_result(struct blob_attr *data)