From patchwork Fri Jan 7 22:42:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 77931 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 14528B715B for ; Sat, 8 Jan 2011 10:13:06 +1100 (EST) Received: from localhost ([127.0.0.1]:48843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PbLEe-0006k8-Ks for incoming@patchwork.ozlabs.org; Fri, 07 Jan 2011 17:56:40 -0500 Received: from [140.186.70.92] (port=49311 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PbL38-000293-4K for qemu-devel@nongnu.org; Fri, 07 Jan 2011 17:44:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PbL1o-0003MB-AE for qemu-devel@nongnu.org; Fri, 07 Jan 2011 17:43:26 -0500 Received: from a.mail.sonic.net ([64.142.16.245]:46699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PbL1n-0003Ld-WC for qemu-devel@nongnu.org; Fri, 07 Jan 2011 17:43:24 -0500 Received: from are.twiddle.net (are.twiddle.net [75.101.38.216]) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id p07Mh5ne001748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 Jan 2011 14:43:06 -0800 Received: from are.twiddle.net (localhost [127.0.0.1]) by are.twiddle.net (8.14.4/8.14.4) with ESMTP id p07Mh54J000937; Fri, 7 Jan 2011 14:43:05 -0800 Received: (from rth@localhost) by are.twiddle.net (8.14.4/8.14.4/Submit) id p07Mh51S000936; Fri, 7 Jan 2011 14:43:05 -0800 From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 7 Jan 2011 14:42:57 -0800 Message-Id: <1294440183-885-2-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.7.2.3 In-Reply-To: <1294440183-885-1-git-send-email-rth@twiddle.net> References: <1294440183-885-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 Cc: Alexander Graf , Aurelien Jarno Subject: [Qemu-devel] [PATCH 1/7] tcg: Define "deposit" as an optional operation. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Richard Henderson --- tcg/README | 14 ++++++++++++++ tcg/tcg-op.h | 40 ++++++++++++++++++++++++++++++++++++++++ tcg/tcg-opc.h | 6 ++++++ tcg/tcg.c | 13 +++++++++++++ 4 files changed, 73 insertions(+), 0 deletions(-) diff --git a/tcg/README b/tcg/README index 68d27ff..ef59070 100644 --- a/tcg/README +++ b/tcg/README @@ -285,6 +285,20 @@ the four high order bytes are set to zero. Indicate that the value of t0 won't be used later. It is useful to force dead code elimination. +* deposit_i32/i64 dest, t1, t2, loc + +Deposit T2 as a bitfield into T1, placing the result in DEST. +The bitfield is described by LOC, an immediate value: + + bits 0:7 - the length of the bitfield + bits 8:15 - the position of the first bit + +For example, 0x101 indicates a 1-bit field at bit 1. +This operation would be equivalent to + + dest = (t1 & ~2) | ((t2 << 1) & 2) + + ********* Conditional moves * setcond_i32/i64 cond, dest, t1, t2 diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index 3ee0a58..c5a019a 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -2071,6 +2071,44 @@ static inline void tcg_gen_rotri_i64(TCGv_i64 ret, TCGv_i64 arg1, int64_t arg2) } } +static inline void tcg_gen_deposit_i32(TCGv_i32 ret, TCGv_i32 arg1, + TCGv_i32 arg2, unsigned int ofs, + unsigned int len) +{ +#ifdef TCG_TARGET_HAS_deposit_i32 + tcg_gen_op4i_i32(INDEX_op_deposit_i32, ret, arg1, arg2, (ofs << 8) | len); +#else + uint32_t mask = (1u << len) - 1; + TCGv_i32 t1 = tcg_temp_new_i32 (); + + tcg_gen_andi_i32(t1, arg2, mask); + tcg_gen_shli_i32(t1, t1, ofs); + tcg_gen_andi_i32(ret, arg1, ~(mask << ofs)); + tcg_gen_or_i32(ret, ret, t1); + + tcg_temp_free_i32(t1); +#endif +} + +static inline void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, + TCGv_i64 arg2, unsigned int ofs, + unsigned int len) +{ +#ifdef TCG_TARGET_HAS_deposit_i64 + tcg_gen_op4i_i64(INDEX_op_deposit_i64, ret, arg1, arg2, (ofs << 8) | len); +#else + uint64_t mask = (1ull << len) - 1; + TCGv_i64 t1 = tcg_temp_new_i64 (); + + tcg_gen_andi_i64(t1, arg2, mask); + tcg_gen_shli_i64(t1, t1, ofs); + tcg_gen_andi_i64(ret, arg1, ~(mask << ofs)); + tcg_gen_or_i64(ret, ret, t1); + + tcg_temp_free_i64(t1); +#endif +} + /***************************************/ /* QEMU specific operations. Their type depend on the QEMU CPU type. */ @@ -2384,6 +2422,7 @@ static inline void tcg_gen_qemu_st64(TCGv_i64 arg, TCGv addr, int mem_index) #define tcg_gen_rotli_tl tcg_gen_rotli_i64 #define tcg_gen_rotr_tl tcg_gen_rotr_i64 #define tcg_gen_rotri_tl tcg_gen_rotri_i64 +#define tcg_gen_deposit_tl tcg_gen_deposit_i64 #define tcg_const_tl tcg_const_i64 #define tcg_const_local_tl tcg_const_local_i64 #else @@ -2454,6 +2493,7 @@ static inline void tcg_gen_qemu_st64(TCGv_i64 arg, TCGv addr, int mem_index) #define tcg_gen_rotli_tl tcg_gen_rotli_i32 #define tcg_gen_rotr_tl tcg_gen_rotr_i32 #define tcg_gen_rotri_tl tcg_gen_rotri_i32 +#define tcg_gen_deposit_tl tcg_gen_deposit_i32 #define tcg_const_tl tcg_const_i32 #define tcg_const_local_tl tcg_const_local_i32 #endif diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h index 2a98fed..ded6311 100644 --- a/tcg/tcg-opc.h +++ b/tcg/tcg-opc.h @@ -78,6 +78,9 @@ DEF(sar_i32, 1, 2, 0, 0) DEF(rotl_i32, 1, 2, 0, 0) DEF(rotr_i32, 1, 2, 0, 0) #endif +#ifdef TCG_TARGET_HAS_deposit_i32 +DEF(deposit_i32, 1, 2, 1, 0) +#endif DEF(brcond_i32, 0, 2, 2, TCG_OPF_BB_END | TCG_OPF_SIDE_EFFECTS) #if TCG_TARGET_REG_BITS == 32 @@ -168,6 +171,9 @@ DEF(sar_i64, 1, 2, 0, 0) DEF(rotl_i64, 1, 2, 0, 0) DEF(rotr_i64, 1, 2, 0, 0) #endif +#ifdef TCG_TARGET_HAS_deposit_i64 +DEF(deposit_i64, 1, 2, 1, 0) +#endif DEF(brcond_i64, 0, 2, 2, TCG_OPF_BB_END | TCG_OPF_SIDE_EFFECTS) #ifdef TCG_TARGET_HAS_ext8s_i64 diff --git a/tcg/tcg.c b/tcg/tcg.c index 5dd6a2c..e95a42f 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -956,6 +956,19 @@ void tcg_dump_ops(TCGContext *s, FILE *outfile) fprintf(outfile, ",$0x%" TCG_PRIlx, args[k++]); i = 1; break; +#if defined(TCG_TARGET_HAS_deposit_i32) || defined(TCG_TARGET_HAS_deposit_i64) +# ifdef TCG_TARGET_HAS_deposit_i32 + case INDEX_op_deposit_i32: +# endif +# ifdef TCG_TARGET_HAS_deposit_i64 + case INDEX_op_deposit_i64: +# endif + fprintf(outfile, ",%u,%u", (unsigned)args[k] >> 8, + (unsigned)args[k] & 0xff); + k++; + i = 1; + break; +#endif default: i = 0; break;