| Message ID | 20170621204827.3259191-1-yhs@fb.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Yonghong Song <yhs@fb.com> Date: Wed, 21 Jun 2017 13:48:27 -0700 > tracex5_kern.c build failed with the following error message: > ../samples/bpf/tracex5_kern.c:12:10: fatal error: 'syscall_nrs.h' file not found > #include "syscall_nrs.h" > The generated file syscall_nrs.h is put in build/samples/bpf directory, > but this directory is not in include path, hence build failed. > > The fix is to add $(obj) into the clang compilation path. > > Signed-off-by: Yonghong Song <yhs@fb.com> Applied, thanks. Please be clear in the future that your patch is targetting 'net-next' by specifying this in your subject lines: [PATCH net-next] ... I had to figure this out by hand. Thank you.
On 6/22/17 8:36 AM, David Miller wrote: > From: Yonghong Song <yhs@fb.com> > Date: Wed, 21 Jun 2017 13:48:27 -0700 > >> tracex5_kern.c build failed with the following error message: >> ../samples/bpf/tracex5_kern.c:12:10: fatal error: 'syscall_nrs.h' file not found >> #include "syscall_nrs.h" >> The generated file syscall_nrs.h is put in build/samples/bpf directory, >> but this directory is not in include path, hence build failed. >> >> The fix is to add $(obj) into the clang compilation path. >> >> Signed-off-by: Yonghong Song <yhs@fb.com> > > Applied, thanks. > > Please be clear in the future that your patch is targetting 'net-next' by > specifying this in your subject lines: > > [PATCH net-next] ... Thanks, Dave. Sorry, I forgot to tag the branch name. I will make sure it happen in the future. > > I had to figure this out by hand. > > Thank you. >
diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index a0561dc..e7ec9b8 100644 --- a/samples/bpf/Makefile +++ b/samples/bpf/Makefile @@ -197,7 +197,7 @@ $(obj)/tracex5_kern.o: $(obj)/syscall_nrs.h # But, there is no easy way to fix it, so just exclude it since it is # useless for BPF samples. $(obj)/%.o: $(src)/%.c - $(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(EXTRA_CFLAGS) \ + $(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(EXTRA_CFLAGS) -I$(obj) \ -D__KERNEL__ -D__ASM_SYSREG_H -Wno-unused-value -Wno-pointer-sign \ -Wno-compare-distinct-pointer-types \ -Wno-gnu-variable-sized-type-not-at-end \
tracex5_kern.c build failed with the following error message: ../samples/bpf/tracex5_kern.c:12:10: fatal error: 'syscall_nrs.h' file not found #include "syscall_nrs.h" The generated file syscall_nrs.h is put in build/samples/bpf directory, but this directory is not in include path, hence build failed. The fix is to add $(obj) into the clang compilation path. Signed-off-by: Yonghong Song <yhs@fb.com> --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)