From patchwork Wed Jun 21 18:20:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 779059 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wtChh6lXBz9s72 for ; Thu, 22 Jun 2017 04:21:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133AbdFUSVX (ORCPT ); Wed, 21 Jun 2017 14:21:23 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:50917 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751434AbdFUSVW (ORCPT ); Wed, 21 Jun 2017 14:21:22 -0400 Received: from localhost.localdomain ([95.90.210.54]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MCuUJ-1dWEoo2buF-009hwt; Wed, 21 Jun 2017 20:20:37 +0200 From: Stefan Wahren To: Linus Walleij , Eric Anholt Cc: Phil Elwell , linux-rpi-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren Subject: [PATCH] pinctrl: bcm2835: Avoid warning from __irq_do_set_handler Date: Wed, 21 Jun 2017 20:20:04 +0200 Message-Id: <1498069204-28154-1-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 2.7.4 X-Provags-ID: V03:K0:ZTNSx+Hl7VM44tMtweAZ09jEq0h2UFfpTkrlizjbSxJz7ZMp6ip QlVPe3HeaY+FTqd10VrjeFM2g+pEiI0JqaUIVhqp1sR97o+yX48PeocAd7Zl5bP8yTqT+HN 6AQ8TPaOYuhahExr7RGTHle9FIKcBeJCDLf8JGAkbRw8oO3Om/GcyG6L+DOQNDNBlhXgjL+ j4NTNyca4AeWyBdUSZsqw== X-UI-Out-Filterresults: notjunk:1; V01:K0:aSAOHCPo0gE=:e+HPb49pPyiK+TkwriK4s4 aXT7YShXeq8YRwrvdVaHqSdMOC2lIDrnYyeJA8OYsNPxzmvNQEDVEysfG56KnnwNkvnRMJyuL 69866agiENJWbJc53i2lsOLODHatgao/UtvDfCRodarViLHHQz1gx93t8E+tdOTV7zJxBbnrF BxrHnSARNhymQK99L9XVPSeW9B7Jc/rM0lzppOTivgNFnR/z162sdbT9lwwVb4KEdGIBunkGz 4Ru2yuvIrBZOfme+Np3EPZdRsSZ2oSh+Zgh8hdgsI993eqbGr+JNbk8+4KyVvd9pW20kIQVAV GbAkeW+dRd1IOUGsv8p5whFDh21d/Fs8KtiZ3vddYTIwPKfRGAVvZWtPrXyzbb7cdkFSoyGOF FyoFP8YGHhwUMSfvP2V8k1BWalgbTsR1AymJzkp/nuA7/vXZlf7byyhOvbA9IBEiJ1foN1SCi fRnvw0P1c7wYcKeFWERvL8kStotxdPWl0qYV/2+sgkkFqcwKAxHEjSnM+e8cn0u9mpCn9PwQa bLaOFbSHD0QyAmU1hTipRdZGOw81LurWH/fwr/5ddL2pt5dcHdJFrXzL8J/ce9BoqiwrByOHk MviZftvrPXZO5ffOZ8JCMJU0MPjCcI0bpiyGQTMhqrCTbHnLQ47Z65uB7yWTO7bP5AJ3TEyY0 grNSGsJeHpMS6hKFsS5CQTCWlimlqoHtpOJ8vyX0WW562/4XWtWZO8RGdkJ3sVmeLqS0= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org We get a warning during boot with enabled EARLY_PRINTK that we try to set a irq_chip without data. This is caused by ignoring the return value of irq_of_parse_and_map(). So avoid calling gpiochip_set_chained_irqchip() in error case. Signed-off-by: Stefan Wahren Fixes: 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP") --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index 1eb7a1a..2308831 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -1048,6 +1048,10 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev) for (i = 0; i < BCM2835_NUM_IRQS; i++) { pc->irq[i] = irq_of_parse_and_map(np, i); pc->irq_group[i] = i; + + if (pc->irq[i] == 0) + continue; + /* * Use the same handler for all groups: this is necessary * since we use one gpiochip to cover all lines - the