Patchwork use __devexit not __exit in n2_unregister_algs fixes build failure on fedora

login
register
mail settings
Submitter Dennis Gilmore
Date Jan. 5, 2011, 7:56 p.m.
Message ID <1294257371-19695-1-git-send-email-dennis@ausil.us>
Download mbox | patch
Permalink /patch/77904/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Dennis Gilmore - Jan. 5, 2011, 7:56 p.m.
From: dennis <dennis@daedalus.ausil.us>

thanks to kylem for helping with debugging
---
 drivers/crypto/n2_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Julian Calaby - Jan. 8, 2011, 12:11 a.m.
On Thu, Jan 6, 2011 at 06:56, Dennis Gilmore <dennis@ausil.us> wrote:
> From: dennis <dennis@daedalus.ausil.us>
>
> thanks to kylem for helping with debugging

Better, but you're still missing your Signed-Off-By and this isn't a
proper patch description - you should, at least, include the error you
were getting.

Also, as this patch is for crypto code, you should probably send it to
their mailing list instead of sparclinux. If you look in the
MAINTAINERS file, you should be able to find the email addresses of
the relevant people.

Thanks,
Dennis Gilmore - Jan. 8, 2011, 12:36 a.m.
On Friday, January 07, 2011 06:11:59 pm Julian Calaby wrote:
> On Thu, Jan 6, 2011 at 06:56, Dennis Gilmore <dennis@ausil.us> wrote:
> > From: dennis <dennis@daedalus.ausil.us>
> > 
> > thanks to kylem for helping with debugging
> 
> Better, but you're still missing your Signed-Off-By and this isn't a
> proper patch description - you should, at least, include the error you
> were getting.
> 
> Also, as this patch is for crypto code, you should probably send it to
> their mailing list instead of sparclinux. If you look in the
> MAINTAINERS file, you should be able to find the email addresses of
> the relevant people.
> 
> Thanks,

Its been sent to the right place and applied already. this was my first attempt 
that git gave an error on sending yesterday. sorry for the nosie

Dennis
Julian Calaby - Jan. 8, 2011, 2:34 a.m.
On Sat, Jan 8, 2011 at 11:36, Dennis Gilmore <dennis@ausil.us> wrote:
> On Friday, January 07, 2011 06:11:59 pm Julian Calaby wrote:
>> On Thu, Jan 6, 2011 at 06:56, Dennis Gilmore <dennis@ausil.us> wrote:
>> > From: dennis <dennis@daedalus.ausil.us>
>> >
>> > thanks to kylem for helping with debugging
>>
>> Better, but you're still missing your Signed-Off-By and this isn't a
>> proper patch description - you should, at least, include the error you
>> were getting.
>>
>> Also, as this patch is for crypto code, you should probably send it to
>> their mailing list instead of sparclinux. If you look in the
>> MAINTAINERS file, you should be able to find the email addresses of
>> the relevant people.
>>
>> Thanks,
>
> Its been sent to the right place and applied already. this was my first attempt
> that git gave an error on sending yesterday. sorry for the nosie

Ah, sorry for the criticism then.

Thanks,

Patch

diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index 88ee015..3372491 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_core.c
@@ -1542,7 +1542,7 @@  out:
 	return err;
 }
 
-static void __exit n2_unregister_algs(void)
+static void __devexit n2_unregister_algs(void)
 {
 	mutex_lock(&spu_lock);
 	if (!--algs_registered)