From patchwork Fri Jan 7 15:58:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Williamson X-Patchwork-Id: 77893 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CCD65B7124 for ; Sat, 8 Jan 2011 03:06:05 +1100 (EST) Received: from localhost ([127.0.0.1]:55003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PbEmP-00019i-Uh for incoming@patchwork.ozlabs.org; Fri, 07 Jan 2011 11:03:05 -0500 Received: from [140.186.70.92] (port=55320 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PbEi9-0007Jq-Je for qemu-devel@nongnu.org; Fri, 07 Jan 2011 10:58:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PbEi8-0005tr-Il for qemu-devel@nongnu.org; Fri, 07 Jan 2011 10:58:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PbEi8-0005te-Av for qemu-devel@nongnu.org; Fri, 07 Jan 2011 10:58:40 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p07FwdvW011869 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Jan 2011 10:58:39 -0500 Received: from s20.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p07FwbLs007753; Fri, 7 Jan 2011 10:58:38 -0500 From: Alex Williamson To: qemu-devel@nongnu.org Date: Fri, 07 Jan 2011 08:58:37 -0700 Message-ID: <20110107155817.12891.70829.stgit@s20.home> In-Reply-To: <20110107071815.26658.403.stgit@s20.home> References: <20110107071815.26658.403.stgit@s20.home> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: alex.williamson@redhat.com, jan.kiszka@web.de, quintela@redhat.com Subject: [Qemu-devel] [PATCH V2] savevm: use error_report for vmstate_save error X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org If migration is done in the background with the -d option, mon is NULL and this error message is lost. Instead use error_report(). Signed-off-by: Alex Williamson Reviewed-by: Jan Kiszka --- savevm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/savevm.c b/savevm.c index 90aa237..148871d 100644 --- a/savevm.c +++ b/savevm.c @@ -1543,7 +1543,7 @@ int qemu_savevm_state_complete(Monitor *mon, QEMUFile *f) r = vmstate_save(f, se); if (r < 0) { - monitor_printf(mon, "cannot migrate with device '%s'\n", se->idstr); + error_report("cannot migrate with device '%s'\n", se->idstr); return r; } }