[1/1] via-velocity: enable perfect filtering for multicast packets

Signed-off-by: Joey Zhuo <joeyzhuo@via.com.tw>
Acked-off-by: Francois Romieu <romieu@fr.zoreil.com>
---
 drivers/net/via-velocity.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

On Fri, 7 Nov 2008 23:36:17 +0100 Francois Romieu <romieu@fr.zoreil.com> wrote:

> Signed-off-by: Joey Zhuo <joeyzhuo@via.com.tw>
> Acked-off-by: Francois Romieu <romieu@fr.zoreil.com>
> ---
>  drivers/net/via-velocity.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
> index 3590ea5..11cb3e5 100644
> --- a/drivers/net/via-velocity.c
> +++ b/drivers/net/via-velocity.c
> @@ -2296,7 +2296,7 @@ static void velocity_set_multi(struct net_device *dev)
>  		}
>  
>  		mac_set_cam_mask(regs, vptr->mCAMmask);
> -		rx_mode = (RCR_AM | RCR_AB);
> +		rx_mode = RCR_AM | RCR_AB | RCR_AP;
>  	}
>  	if (dev->mtu > 1500)
>  		rx_mode |= RCR_AL;

Is this a bugfix, a regression fix or a feature?

I assume that it was authored by Joey?  The way to communicate that is
to put his From: line at the top of the changelog.  As it stands, this
patch appears to have been authored by yourself.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Fri, 7 Nov 2008 23:36:17 +0100 Francois Romieu <romieu@fr.zoreil.com> wrote:

> Signed-off-by: Joey Zhuo <joeyzhuo@via.com.tw>
> Acked-off-by: Francois Romieu <romieu@fr.zoreil.com>

ooh, we need a Hacked-off-by too :)

I guess you meant Acked-by:, but as you were on the delivery path for
this patch, a Signed-off-by: is more appropriate.


> --- a/drivers/net/via-velocity.c
> +++ b/drivers/net/via-velocity.c
> @@ -2296,7 +2296,7 @@ static void velocity_set_multi(struct net_device *dev)
>  		}
>  
>  		mac_set_cam_mask(regs, vptr->mCAMmask);
> -		rx_mode = (RCR_AM | RCR_AB);
> +		rx_mode = RCR_AM | RCR_AB | RCR_AP;
>  	}
>  	if (dev->mtu > 1500)
>  		rx_mode |= RCR_AL;

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Andrew Morton <akpm@linux-foundation.org> :
[...]
> Is this a bugfix, a regression fix or a feature?

It is not a regression fix. I would say thet it is somewhere between
the bugfix and the feature.

> 
> I assume that it was authored by Joey ?

Yes.