[LEDE-DEV] busybox: re-enable telnet applet

Message ID 20170620171303.GL4944@zirkel.wertarbyte.de
State Rejected
Delegated to: John Crispin
Headers show

Commit Message

Stefan Tomanek June 20, 2017, 5:13 p.m.
While sshd should be favoured over telnetd, having a telnet client on the
router is useful for connecting to other devices in the same LAN.

Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
---
 package/utils/busybox/Config-defaults.in |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

John Crispin Feb. 18, 2018, 9:27 a.m. | #1
On 20/06/17 19:13, Stefan Tomanek wrote:
> While sshd should be favoured over telnetd, having a telnet client on the
> router is useful for connecting to other devices in the same LAN.
>
> Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de>

sorry for the late reply, it has been discussed over and over and the 
decision was made to not enable telnet by default. sorry ...

     John
> ---
>   package/utils/busybox/Config-defaults.in |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in
> index 1977e7f..9e0efcf 100644
> --- a/package/utils/busybox/Config-defaults.in
> +++ b/package/utils/busybox/Config-defaults.in
> @@ -2289,10 +2289,10 @@ config BUSYBOX_DEFAULT_TCPSVD
>   	default n
>   config BUSYBOX_DEFAULT_TELNET
>   	bool
> -	default n
> +	default y
>   config BUSYBOX_DEFAULT_FEATURE_TELNET_TTYPE
>   	bool
> -	default n
> +	default y
>   config BUSYBOX_DEFAULT_FEATURE_TELNET_AUTOLOGIN
>   	bool
>   	default n
Philip Prindeville Feb. 18, 2018, 6:25 p.m. | #2
> On Feb 18, 2018, at 2:27 AM, John Crispin <john@phrozen.org> wrote:
> 
> 
> 
>> On 20/06/17 19:13, Stefan Tomanek wrote:
>> While sshd should be favoured over telnetd, having a telnet client on the
>> router is useful for connecting to other devices in the same LAN.
>> 
>> Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
> 
> sorry for the late reply, it has been discussed over and over and the decision was made to not enable telnet by default. sorry ...
> 
>     John

Too bad.  While it’s a liability for logging in, it’s a great tool for testing remote services like HTTP, SMTP, IMAP, JetDirect printers, etc.


>> ---
>>  package/utils/busybox/Config-defaults.in |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in
>> index 1977e7f..9e0efcf 100644
>> --- a/package/utils/busybox/Config-defaults.in
>> +++ b/package/utils/busybox/Config-defaults.in
>> @@ -2289,10 +2289,10 @@ config BUSYBOX_DEFAULT_TCPSVD
>>      default n
>>  config BUSYBOX_DEFAULT_TELNET
>>      bool
>> -    default n
>> +    default y
>>  config BUSYBOX_DEFAULT_FEATURE_TELNET_TTYPE
>>      bool
>> -    default n
>> +    default y
>>  config BUSYBOX_DEFAULT_FEATURE_TELNET_AUTOLOGIN
>>      bool
>>      default n
> 
> 
> _______________________________________________
> Lede-dev mailing list
> Lede-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev
Philip Prindeville Feb. 18, 2018, 8:26 p.m. | #3
> On Feb 18, 2018, at 11:25 AM, Philip Prindeville <philipp_subx@redfish-solutions.com> wrote:
> 
> 
> 
>> On Feb 18, 2018, at 2:27 AM, John Crispin <john@phrozen.org> wrote:
>> 
>> 
>> 
>>> On 20/06/17 19:13, Stefan Tomanek wrote:
>>> While sshd should be favoured over telnetd, having a telnet client on the
>>> router is useful for connecting to other devices in the same LAN.
>>> 
>>> Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
>> 
>> sorry for the late reply, it has been discussed over and over and the decision was made to not enable telnet by default. sorry ...
>> 
>>    John
> 
> Too bad.  While it’s a liability for logging in, it’s a great tool for testing remote services like HTTP, SMTP, IMAP, JetDirect printers, etc.


Although we should be honest about it: the problem isn’t the host with the telnet client; it’s the one with the telnet server.

-Philip


>>> ---
>>> package/utils/busybox/Config-defaults.in |    4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in
>>> index 1977e7f..9e0efcf 100644
>>> --- a/package/utils/busybox/Config-defaults.in
>>> +++ b/package/utils/busybox/Config-defaults.in
>>> @@ -2289,10 +2289,10 @@ config BUSYBOX_DEFAULT_TCPSVD
>>>     default n
>>> config BUSYBOX_DEFAULT_TELNET
>>>     bool
>>> -    default n
>>> +    default y
>>> config BUSYBOX_DEFAULT_FEATURE_TELNET_TTYPE
>>>     bool
>>> -    default n
>>> +    default y
>>> config BUSYBOX_DEFAULT_FEATURE_TELNET_AUTOLOGIN
>>>     bool
>>>     default n
>> 
>>
edgar.soldin@web.de Feb. 18, 2018, 9:21 p.m. | #4
On 2/18/2018 21:26, Philip Prindeville wrote:
> 
>> On Feb 18, 2018, at 11:25 AM, Philip Prindeville <philipp_subx@redfish-solutions.com> wrote:
>>
>>
>>
>>> On Feb 18, 2018, at 2:27 AM, John Crispin <john@phrozen.org> wrote:
>>>
>>>
>>>
>>>> On 20/06/17 19:13, Stefan Tomanek wrote:
>>>> While sshd should be favoured over telnetd, having a telnet client on the
>>>> router is useful for connecting to other devices in the same LAN.
>>>>
>>>> Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
>>>
>>> sorry for the late reply, it has been discussed over and over and the decision was made to not enable telnet by default. sorry ...
>>>
>>>    John
>>
>> Too bad.  While it’s a liability for logging in, it’s a great tool for testing remote services like HTTP, SMTP, IMAP, JetDirect printers, etc.
> 
SNIP

looks like it is possible to keep the telnet applet only, not telnetd. if this is not wanted for size, is there an alternative to interact with a port pushing/receiving characters?

..ede
Alberto Bursi Feb. 18, 2018, 10:49 p.m. | #5
On 02/18/2018 10:21 PM, edgar.soldin@web.de wrote:
> On 2/18/2018 21:26, Philip Prindeville wrote:
>>> On Feb 18, 2018, at 11:25 AM, Philip Prindeville <philipp_subx@redfish-solutions.com> wrote:
>>>
>>>
>>>
>>>> On Feb 18, 2018, at 2:27 AM, John Crispin <john@phrozen.org> wrote:
>>>>
>>>>
>>>>
>>>>> On 20/06/17 19:13, Stefan Tomanek wrote:
>>>>> While sshd should be favoured over telnetd, having a telnet client on the
>>>>> router is useful for connecting to other devices in the same LAN.
>>>>>
>>>>> Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
>>>> sorry for the late reply, it has been discussed over and over and the decision was made to not enable telnet by default. sorry ...
>>>>
>>>>     John
>>> Too bad.  While it’s a liability for logging in, it’s a great tool for testing remote services like HTTP, SMTP, IMAP, JetDirect printers, etc.
> SNIP
>
> looks like it is possible to keep the telnet applet only, not telnetd. if this is not wanted for size, is there an alternative to interact with a port pushing/receiving characters?
>
> ..ede
>
> _______________________________________________
>

There is a closed (not merged) PR for the packages repo that adds 
telnet-bsd package, which is a commonly used telnet client, and is 
independent from Busybox. The code is still available, and should work fine.
https://github.com/openwrt/packages/pull/4509

-Alberto
Paul Oranje Feb. 20, 2018, 12:13 a.m. | #6
Who needs telnet when nc is there ?

> Op 18 feb. 2018, om 19:25 heeft Philip Prindeville <philipp_subx@redfish-solutions.com> het volgende geschreven:
> 
> 
> 
>> On Feb 18, 2018, at 2:27 AM, John Crispin <john@phrozen.org> wrote:
>> 
>> 
>> 
>>> On 20/06/17 19:13, Stefan Tomanek wrote:
>>> While sshd should be favoured over telnetd, having a telnet client on the
>>> router is useful for connecting to other devices in the same LAN.
>>> 
>>> Signed-off-by: Stefan Tomanek <stefan.tomanek@wertarbyte.de>
>> 
>> sorry for the late reply, it has been discussed over and over and the decision was made to not enable telnet by default. sorry ...
>> 
>>    John
> 
> Too bad.  While it’s a liability for logging in, it’s a great tool for testing remote services like HTTP, SMTP, IMAP, JetDirect printers, etc.
> 
> 
>>> ---
>>> package/utils/busybox/Config-defaults.in |    4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in
>>> index 1977e7f..9e0efcf 100644
>>> --- a/package/utils/busybox/Config-defaults.in
>>> +++ b/package/utils/busybox/Config-defaults.in
>>> @@ -2289,10 +2289,10 @@ config BUSYBOX_DEFAULT_TCPSVD
>>>     default n
>>> config BUSYBOX_DEFAULT_TELNET
>>>     bool
>>> -    default n
>>> +    default y
>>> config BUSYBOX_DEFAULT_FEATURE_TELNET_TTYPE
>>>     bool
>>> -    default n
>>> +    default y
>>> config BUSYBOX_DEFAULT_FEATURE_TELNET_AUTOLOGIN
>>>     bool
>>>     default n
>> 
>> 
>> _______________________________________________
>> Lede-dev mailing list
>> Lede-dev@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/lede-dev
> 
> 
> _______________________________________________
> Lede-dev mailing list
> Lede-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev

Patch

diff --git a/package/utils/busybox/Config-defaults.in b/package/utils/busybox/Config-defaults.in
index 1977e7f..9e0efcf 100644
--- a/package/utils/busybox/Config-defaults.in
+++ b/package/utils/busybox/Config-defaults.in
@@ -2289,10 +2289,10 @@  config BUSYBOX_DEFAULT_TCPSVD
 	default n
 config BUSYBOX_DEFAULT_TELNET
 	bool
-	default n
+	default y
 config BUSYBOX_DEFAULT_FEATURE_TELNET_TTYPE
 	bool
-	default n
+	default y
 config BUSYBOX_DEFAULT_FEATURE_TELNET_AUTOLOGIN
 	bool
 	default n