| Message ID | 1497962468-22936-1-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1497962468-22936-1-git-send-email-armbru@redhat.com
Subject: [Qemu-devel] [PULL v2 00/41] QAPI patches for 2017-06-09
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a4e8dac tests/qdict: check more get_try_int() cases
f19e899 console: use get_uint() for "head" property
c23cbd5 i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties
ee6c66c numa: use get_uint() for "size" property
fc06041 pnv-core: use get_uint() for "core-pir" property
56d8304 pvpanic: use get_uint() for "ioport" property
64ae787 auxbus: use get_uint() for "addr" property
c125082 arm: use get_uint() for "mp-affinity" property
83a3433 xen: use get_uint() for "max-ram-below-4g" property
7e3b57d pc: use get_uint() for "hpet-intcap" property
c2e6cf3 pc: use get_uint() for "apic-id" property
8453cc9 pc: use get_uint() for "iobase" property
0676b98 acpi: use get_uint() for "pci-hole*" properties
2d0badd acpi: use get_uint() for various acpi properties
93b3df9 acpi: use get_uint() for "acpi-pcihp-io*" properties
6625c7c platform-bus: use get_uint() for "addr" property
96d6aba bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base"
d107f50 aspeed: use {set, get}_uint() for "ram-size" property
3d8b453 pcihp: use get_uint() for "bsel" property
e61ff60 pc-dimm: make "size" property uint64
25fce56 pc-dimm: use get_uint() for dimm properties
35641f6 isa: use get_uint() for "io-base"
53fb92e qdev: Use appropriate getter/setters type
fc9a390 apic-common: make "id" property a uint32
58b5fe1 qdev: avoid type casts between signed and unsigned
b2a3cbf qdev: wrap default property value in an union
46b185b qdev: Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_SIGNED()
efded0d object: use more specific property type names
e13f177 q35: fix get_mmcfg_size to use uint64 visitor
c20018f object: add uint property setter/getter
ded896a qapi: update the qobject visitor to use QNUM_U64
ef6ccb0 json: learn to parse uint64 numbers
ef5a970 qnum: add uint type
71c4589 tests: remove /{qnum, qlist, dict}/destroy test
3d17cba qapi: Remove visit_start_alternate() parameter promote_int
7f96333 qapi: merge QInt and QFloat in QNum
22c66a1 qapi: Clean up qobject_input_type_number() control flow
224785d tests: add more int/number ranges checks
6ee38b3 tests: Remove test cases for alternates of 'number' and 'int'
b23e9b3 object: fix potential leak in getters
4632090 qdev: remove PropertyInfo.qtype field
=== OUTPUT BEGIN ===
Checking PATCH 1/41: qdev: remove PropertyInfo.qtype field...
Checking PATCH 2/41: object: fix potential leak in getters...
Checking PATCH 3/41: tests: Remove test cases for alternates of 'number' and 'int'...
Checking PATCH 4/41: tests: add more int/number ranges checks...
Checking PATCH 5/41: qapi: Clean up qobject_input_type_number() control flow...
Checking PATCH 6/41: qapi: merge QInt and QFloat in QNum...
ERROR: do not use C99 // comments
#1975: FILE: tests/check-qnum.c:39:
+ // destroy doesn't exit yet
ERROR: do not use C99 // comments
#1991: FILE: tests/check-qnum.c:55:
+ // destroy doesn't exit yet
total: 2 errors, 0 warnings, 1894 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/41: qapi: Remove visit_start_alternate() parameter promote_int...
Checking PATCH 8/41: tests: remove /{qnum, qlist, dict}/destroy test...
Checking PATCH 9/41: qnum: add uint type...
Checking PATCH 10/41: json: learn to parse uint64 numbers...
Checking PATCH 11/41: qapi: update the qobject visitor to use QNUM_U64...
Checking PATCH 12/41: object: add uint property setter/getter...
Checking PATCH 13/41: q35: fix get_mmcfg_size to use uint64 visitor...
Checking PATCH 14/41: object: use more specific property type names...
Checking PATCH 15/41: qdev: Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_SIGNED()...
Checking PATCH 16/41: qdev: wrap default property value in an union...
Checking PATCH 17/41: qdev: avoid type casts between signed and unsigned...
Checking PATCH 18/41: apic-common: make "id" property a uint32...
Checking PATCH 19/41: qdev: Use appropriate getter/setters type...
Checking PATCH 20/41: isa: use get_uint() for "io-base"...
Checking PATCH 21/41: pc-dimm: use get_uint() for dimm properties...
Checking PATCH 22/41: pc-dimm: make "size" property uint64...
Checking PATCH 23/41: pcihp: use get_uint() for "bsel" property...
Checking PATCH 24/41: aspeed: use {set, get}_uint() for "ram-size" property...
Checking PATCH 25/41: bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base"...
Checking PATCH 26/41: platform-bus: use get_uint() for "addr" property...
Checking PATCH 27/41: acpi: use get_uint() for "acpi-pcihp-io*" properties...
Checking PATCH 28/41: acpi: use get_uint() for various acpi properties...
Checking PATCH 29/41: acpi: use get_uint() for "pci-hole*" properties...
Checking PATCH 30/41: pc: use get_uint() for "iobase" property...
Checking PATCH 31/41: pc: use get_uint() for "apic-id" property...
Checking PATCH 32/41: pc: use get_uint() for "hpet-intcap" property...
Checking PATCH 33/41: xen: use get_uint() for "max-ram-below-4g" property...
Checking PATCH 34/41: arm: use get_uint() for "mp-affinity" property...
Checking PATCH 35/41: auxbus: use get_uint() for "addr" property...
Checking PATCH 36/41: pvpanic: use get_uint() for "ioport" property...
Checking PATCH 37/41: pnv-core: use get_uint() for "core-pir" property...
Checking PATCH 38/41: numa: use get_uint() for "size" property...
Checking PATCH 39/41: i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties...
Checking PATCH 40/41: console: use get_uint() for "head" property...
Checking PATCH 41/41: tests/qdict: check more get_try_int() cases...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
On 20 June 2017 at 13:40, Markus Armbruster <armbru@redhat.com> wrote: > The following changes since commit edf8bc98424d62035d5e4c0f39542722d72d7979: > > Merge remote-tracking branch 'remotes/rth/tags/pull-s390-20170613' into staging (2017-06-15 13:45:15 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-06-09-v2 > > for you to fetch changes up to 269c20b2bbd2aa8531e0cdc741fb166f290d7a2b: > > tests/qdict: check more get_try_int() cases (2017-06-20 14:31:33 +0200) > > ---------------------------------------------------------------- > QAPI patches for 2017-06-09 > > ---------------------------------------------------------------- Applied, thanks. -- PMM
The following changes since commit edf8bc98424d62035d5e4c0f39542722d72d7979: Merge remote-tracking branch 'remotes/rth/tags/pull-s390-20170613' into staging (2017-06-15 13:45:15 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-06-09-v2 for you to fetch changes up to 269c20b2bbd2aa8531e0cdc741fb166f290d7a2b: tests/qdict: check more get_try_int() cases (2017-06-20 14:31:33 +0200) ---------------------------------------------------------------- QAPI patches for 2017-06-09 ---------------------------------------------------------------- Marc-André Lureau (41): qdev: remove PropertyInfo.qtype field object: fix potential leak in getters tests: Remove test cases for alternates of 'number' and 'int' tests: add more int/number ranges checks qapi: Clean up qobject_input_type_number() control flow qapi: merge QInt and QFloat in QNum qapi: Remove visit_start_alternate() parameter promote_int tests: remove /{qnum, qlist, dict}/destroy test qnum: add uint type json: learn to parse uint64 numbers qapi: update the qobject visitor to use QNUM_U64 object: add uint property setter/getter q35: fix get_mmcfg_size to use uint64 visitor object: use more specific property type names qdev: Rename DEFINE_PROP_DEFAULT() to DEFINE_PROP_SIGNED() qdev: wrap default property value in an union qdev: avoid type casts between signed and unsigned apic-common: make "id" property a uint32 qdev: Use appropriate getter/setters type isa: use get_uint() for "io-base" pc-dimm: use get_uint() for dimm properties pc-dimm: make "size" property uint64 pcihp: use get_uint() for "bsel" property aspeed: use {set, get}_uint() for "ram-size" property bcm2835_fb: use {get, set}_uint() for "vcram-size" and "vcram-base" platform-bus: use get_uint() for "addr" property acpi: use get_uint() for "acpi-pcihp-io*" properties acpi: use get_uint() for various acpi properties acpi: use get_uint() for "pci-hole*" properties pc: use get_uint() for "iobase" property pc: use get_uint() for "apic-id" property pc: use get_uint() for "hpet-intcap" property xen: use get_uint() for "max-ram-below-4g" property arm: use get_uint() for "mp-affinity" property auxbus: use get_uint() for "addr" property pvpanic: use get_uint() for "ioport" property pnv-core: use get_uint() for "core-pir" property numa: use get_uint() for "size" property i386/cpu: use get_uint() for "min-level"/"min-xlevel" properties console: use get_uint() for "head" property tests/qdict: check more get_try_int() cases MAINTAINERS | 3 +- backends/cryptodev.c | 2 +- block/blkdebug.c | 1 - block/nbd.c | 1 - block/nfs.c | 1 - block/qapi.c | 13 +- block/quorum.c | 1 - block/sheepdog.c | 1 - block/ssh.c | 1 - block/vvfat.c | 1 - blockdev.c | 5 +- hw/acpi/memory_hotplug.c | 12 +- hw/acpi/nvdimm.c | 18 +-- hw/acpi/pcihp.c | 7 +- hw/arm/aspeed.c | 8 +- hw/arm/bcm2835_peripherals.c | 9 +- hw/arm/raspi.c | 4 +- hw/block/fdc.c | 18 +-- hw/core/platform-bus.c | 2 +- hw/core/qdev-properties.c | 40 +++++- hw/core/qdev.c | 13 +- hw/i386/acpi-build.c | 69 +++++----- hw/i386/pc.c | 6 +- hw/i386/xen/xen-hvm.c | 6 +- hw/intc/apic_common.c | 10 +- hw/intc/arm_gicv3_common.c | 2 +- hw/mem/pc-dimm.c | 23 ++-- hw/misc/auxbus.c | 2 +- hw/misc/pvpanic.c | 2 +- hw/net/e1000e.c | 6 +- hw/pci-host/gpex.c | 2 +- hw/pci-host/piix.c | 8 +- hw/pci-host/q35.c | 15 +-- hw/pci-host/xilinx-pcie.c | 2 +- hw/ppc/pnv.c | 2 +- hw/ppc/pnv_core.c | 2 +- hw/ppc/spapr.c | 7 +- hw/usb/xen-usb.c | 1 - include/hw/isa/isa.h | 2 +- include/hw/qdev-core.h | 7 +- include/hw/qdev-properties.h | 50 ++++--- include/qapi/qmp/qdict.h | 3 +- include/qapi/qmp/qfloat.h | 29 ---- include/qapi/qmp/qint.h | 28 ---- include/qapi/qmp/qlist.h | 3 +- include/qapi/qmp/qnum.h | 53 ++++++++ include/qapi/qmp/types.h | 3 +- include/qapi/qobject-input-visitor.h | 6 +- include/qapi/qobject-output-visitor.h | 8 +- include/qapi/visitor-impl.h | 2 +- include/qapi/visitor.h | 4 +- include/qom/object.h | 23 ++++ monitor.c | 2 +- net/dump.c | 2 +- net/filter-buffer.c | 2 +- numa.c | 6 +- qapi/qapi-clone-visitor.c | 2 +- qapi/qapi-dealloc-visitor.c | 2 +- qapi/qapi-visit-core.c | 6 +- qapi/qobject-input-visitor.c | 58 ++++---- qapi/qobject-output-visitor.c | 7 +- qapi/trace-events | 2 +- qga/commands.c | 2 +- qga/main.c | 1 - qobject/Makefile.objs | 2 +- qobject/json-lexer.c | 4 + qobject/json-parser.c | 56 +++++--- qobject/qdict.c | 37 +++-- qobject/qfloat.c | 62 --------- qobject/qint.c | 61 --------- qobject/qjson.c | 37 +---- qobject/qnum.c | 223 +++++++++++++++++++++++++++++++ qobject/qobject.c | 3 +- qom/object.c | 51 +++++-- scripts/coccinelle/qobject.cocci | 4 +- scripts/qapi-visit.py | 12 +- scripts/qapi.py | 36 +++-- target/i386/cpu.c | 10 +- tests/.gitignore | 3 +- tests/Makefile.include | 13 +- tests/check-qdict.c | 39 +++--- tests/check-qfloat.c | 53 -------- tests/check-qint.c | 87 ------------ tests/check-qjson.c | 135 +++++++++++++------ tests/check-qlist.c | 40 ++---- tests/check-qnum.c | 170 +++++++++++++++++++++++ tests/check-qstring.c | 9 -- tests/qapi-schema/comments.out | 2 +- tests/qapi-schema/doc-good.out | 2 +- tests/qapi-schema/empty.out | 2 +- tests/qapi-schema/event-case.out | 2 +- tests/qapi-schema/ident-with-escape.out | 2 +- tests/qapi-schema/include-relpath.out | 2 +- tests/qapi-schema/include-repetition.out | 2 +- tests/qapi-schema/include-simple.out | 2 +- tests/qapi-schema/indented-expr.out | 2 +- tests/qapi-schema/qapi-schema-test.json | 2 - tests/qapi-schema/qapi-schema-test.out | 10 +- tests/test-keyval.c | 4 +- tests/test-qmp-commands.c | 8 +- tests/test-qmp-event.c | 9 +- tests/test-qobject-input-visitor.c | 112 +++++++++------- tests/test-qobject-output-visitor.c | 93 ++++++++----- tests/test-x86-cpuid-compat.c | 18 ++- ui/console.c | 4 +- ui/spice-core.c | 1 - ui/vnc-enc-tight.c | 1 - util/qemu-option.c | 24 ++-- 108 files changed, 1155 insertions(+), 935 deletions(-) delete mode 100644 include/qapi/qmp/qfloat.h delete mode 100644 include/qapi/qmp/qint.h create mode 100644 include/qapi/qmp/qnum.h delete mode 100644 qobject/qfloat.c delete mode 100644 qobject/qint.c create mode 100644 qobject/qnum.c delete mode 100644 tests/check-qfloat.c delete mode 100644 tests/check-qint.c create mode 100644 tests/check-qnum.c